From: Hanna Czenczek <hreitz@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
"Albert Esteve" <aesteve@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Garhwal, Vikram" <vikram.garhwal@amd.com>
Subject: Re: [PATCH] vhost-user: Fix protocol feature bit conflict
Date: Tue, 17 Oct 2023 10:14:39 +0200 [thread overview]
Message-ID: <50116c43-5fb6-ad87-a748-12e02d596c13@redhat.com> (raw)
In-Reply-To: <20231017075352.2l3htkj46gunyjrm@vireshk-i7>
On 17.10.23 09:53, Viresh Kumar wrote:
> On 17-10-23, 09:51, Hanna Czenczek wrote:
>> Not that I’m really opposed to that, but I don’t see the problem with just
>> doing that in the same work that makes qemu actually use this flag, exactly
>> because it’s just a -1/+1 change.
>>
>> I can send a v2, but should I do the same for libvhost-user and define the
>> flag there? Do I have to add a patch to do the same for F_STATUS, which so
>> far only got a placeholder comment?
> Sure, that's fine too.
I would rather not, though, and don’t see a tangible benefit in doing so.
next prev parent reply other threads:[~2023-10-17 8:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 8:32 [PATCH] vhost-user: Fix protocol feature bit conflict Hanna Czenczek
2023-10-16 8:45 ` Manos Pitsidianakis
2023-10-16 10:32 ` Viresh Kumar
2023-10-16 11:40 ` Alex Bennée
2023-10-17 5:36 ` Viresh Kumar
2023-10-17 7:51 ` Hanna Czenczek
2023-10-17 7:53 ` Viresh Kumar
2023-10-17 8:14 ` Hanna Czenczek [this message]
2023-10-17 8:16 ` Viresh Kumar
2023-10-17 8:25 ` Albert Esteve
2023-10-17 10:56 ` Stefan Hajnoczi
2023-10-17 14:38 ` Albert Esteve
2023-10-17 14:46 ` Stefan Hajnoczi
2023-10-16 12:01 ` Manos Pitsidianakis
2023-10-16 10:40 ` Hanna Czenczek
2023-10-16 10:13 ` Stefano Garzarella
2023-10-16 14:03 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50116c43-5fb6-ad87-a748-12e02d596c13@redhat.com \
--to=hreitz@redhat.com \
--cc=aesteve@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vikram.garhwal@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).