From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SuSyK-0001Jn-1e
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:39:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SuSyI-00066T-UR
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:39:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SuSyI-00066C-M5
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:39:38 -0400
Message-ID: <50117772.3080903@redhat.com>
Date: Thu, 26 Jul 2012 18:59:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com>
	<1343127865-16608-3-git-send-email-pbonzini@redhat.com>
	<501161A4.6000800@redhat.com> <5011650D.1050100@redhat.com>
	<20120726134925.5d9512b2@doriath.home>
In-Reply-To: <20120726134925.5d9512b2@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce
	QERR_BLOCK_JOB_NOT_ACTIVE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 26/07/2012 18:49, Luiz Capitulino ha scritto:
> On Thu, 26 Jul 2012 17:41:01 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>> Il 26/07/2012 17:26, Kevin Wolf ha scritto:
>>>> The DeviceNotActive error is not a particularly good match, add
>>>>> a separate one.
>>>>>
>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Luiz, what do you think about this one? It seems to contradict the idea
>>> of having only few error classes and free form error descriptions.
>>
>> I agree, but that's what we have to live with for now...
> 
> Why don't you add QERR_INVALID_STATE then?

Because I do want a meaningful error message.

Paolo

>>
>>> What's the error class that we should really have here? A general
>>> QERR_NOT_ACTIVE?
>>
>> See my proposal here:
>> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg00061.html
>> (totally ignored ;)).
>>
>> This would be QERR_INVALID_STATE (quoting from that message:
>> "InvalidStateError is generally caused by the interaction with other
>> commands, could be fixed by sending some commands and retrying").
>>
>> Paolo
>>
>