From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey
Date: Thu, 26 Jul 2012 15:22:25 -0600 [thread overview]
Message-ID: <5011B511.70601@redhat.com> (raw)
In-Reply-To: <1343278141-10843-7-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On 07/25/2012 10:49 PM, Amos Kong wrote:
> Convert 'sendkey' to use QAPI.
>
> Keys' indexes in the enmu are same as keycodes' indexes in the
s/enmu/enum/
> key_defs[], index_from_code() and index_from_key() will return
> Q_KEY_CODE_MAX if the code/key is invalid.
>
> For qmp, QAPI would check invalid key and raise error.
> For hmp, invalid key is checked in hmp_send_key().
>
> 'send-key' of QMP doesn't support key in hexadecimal format.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
I glanced through the series, and didn't see anything else suspicious
from my point of view. The QMP interface which libvirt will be using
appears to be sane.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-07-26 21:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 4:48 [Qemu-devel] [PATCH v5 0/6] convert sendkey to qapi Amos Kong
2012-07-26 4:48 ` [Qemu-devel] [PATCH v5 1/6] fix doc of using raw values with sendkey Amos Kong
2012-07-26 4:48 ` [Qemu-devel] [PATCH v5 2/6] monitor: rename keyname '<' to 'less' Amos Kong
2012-07-26 4:48 ` [Qemu-devel] [PATCH v5 3/6] hmp: rename arguments Amos Kong
2012-07-26 4:48 ` [Qemu-devel] [PATCH v5 4/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-07-26 4:49 ` [Qemu-devel] [PATCH v5 5/6] ps2: output warning when event queue full Amos Kong
2012-07-27 19:24 ` Blue Swirl
2012-07-26 4:49 ` [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey Amos Kong
2012-07-26 21:22 ` Eric Blake [this message]
2012-08-02 19:57 ` Luiz Capitulino
2012-08-03 1:38 ` Amos Kong
2012-08-03 13:23 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5011B511.70601@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).