From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuVVv-0002cf-Ot for qemu-devel@nongnu.org; Thu, 26 Jul 2012 17:22:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuVVs-0004xa-Ov for qemu-devel@nongnu.org; Thu, 26 Jul 2012 17:22:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuVVs-0004xA-HJ for qemu-devel@nongnu.org; Thu, 26 Jul 2012 17:22:28 -0400 Message-ID: <5011B511.70601@redhat.com> Date: Thu, 26 Jul 2012 15:22:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343278141-10843-1-git-send-email-akong@redhat.com> <1343278141-10843-7-git-send-email-akong@redhat.com> In-Reply-To: <1343278141-10843-7-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD374505D6D881458AE934569" Subject: Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD374505D6D881458AE934569 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 10:49 PM, Amos Kong wrote: > Convert 'sendkey' to use QAPI. >=20 > Keys' indexes in the enmu are same as keycodes' indexes in the s/enmu/enum/ > key_defs[], index_from_code() and index_from_key() will return > Q_KEY_CODE_MAX if the code/key is invalid. >=20 > For qmp, QAPI would check invalid key and raise error. > For hmp, invalid key is checked in hmp_send_key(). >=20 > 'send-key' of QMP doesn't support key in hexadecimal format. >=20 > Signed-off-by: Amos Kong I glanced through the series, and didn't see anything else suspicious from my point of view. The QMP interface which libvirt will be using appears to be sane. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD374505D6D881458AE934569 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEbUSAAoJEKeha0olJ0NqIVsH/iPOOtG0EjjfmLK7SmyC4WNA EkEjY8W5wl8Y9C/30NZA97AiUaYWgL0EH+xXfBHtTmrHruNKvD0Tl4nKVfTKH6DF KNYK7L9oQiZnL2iqOd2A4uPF9XXNk9HhZ6j+ZlUjIx0hQOi5v87ngHcXVJWHWo91 HbCKYUPfeoEUghZGqQ/tRRfsbusT7u1LwLTQkAuAHhC4fHf8AtFD1d89NH1n1b7A GJ4qPwIZuj7oEu6WyuAd9QKIIDZyXPIWQM2F2GvO4vv2HejZ+Xz3st5+cCTqR5sO QOjFeUQPZOIRHiCHrT+xPyzVq1MW/+dXJhYZ9rP5/rNwO4Gajs5Kt5KyhfIDNbQ= =FlZx -----END PGP SIGNATURE----- --------------enigD374505D6D881458AE934569--