From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuWkA-0008Aq-1j for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:41:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuWk7-0004CB-S2 for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:41:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuWk7-0004BL-JA for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:41:15 -0400 Message-ID: <5011C77E.7050901@redhat.com> Date: Thu, 26 Jul 2012 16:41:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343227834-5400-1-git-send-email-owasserm@redhat.com> <1343227834-5400-11-git-send-email-owasserm@redhat.com> In-Reply-To: <1343227834-5400-11-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0F439D4F6D09063EF4FD33EA" Subject: Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0F439D4F6D09063EF4FD33EA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 08:50 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qapi-schema.json > @@ -264,11 +264,15 @@ > # migration has ended, it returns the total migration > # time. (since 1.2) > # > -# Since: 0.14.0. > +# @duplicate: #optional, number of duplicate pages (since 1.2) I think I was the one that originally asked whether #optional was appropriate for back-compat reasons when adding to a struct, but Luis has since corrected me - #optional only makes sense for a return member that will not appear in all uses of the struct in the current version. But the number of duplicates is always available (even if it is 0), so it should not be optional. That is, this line should be: # @duplicate: number of duplicate pages (since 1.2) > +# > +# @normal : #optional, number of normal pages (since 1.2) Likewise. > +# > +# Since: 0.14.0 > ## > { 'type': 'MigrationStats', > 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , > - 'total_time': 'int' } } > + 'total_time': 'int', '*duplicate': 'int', '*normal': 'int' = } } and this should be 'duplicate' and 'normal'. > +++ b/qmp-commands.hx > @@ -2099,6 +2099,8 @@ The main json-object contains the following: > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > + - "duplicate": number of duplicated pages (json-int) > + - "normal" : number of normal pages transferred (json-int) > - "disk": only present if "status" is "active" and it is a block migra= tion, > it is a json-object with the following disk information (in bytes): > - "transferred": amount transferred (json-int) >=20 Incomplete if we decide that 'duplicate' and 'normal' are not optional; we should be updating example 4 and 5 to list the new fields. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0F439D4F6D09063EF4FD33EA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEcd+AAoJEKeha0olJ0NqCiAH/1MP2MKLfsRlrvQRmnJ5fPgl dDMqLo7DBctX8LTywhAnDO5pXlE6OtcApkmOPz0MCHOIvlhWHI3D9dic/59e4x9N FWYKA7on3vQEWTComRD0/luPtaMeO53y++4wUg74ypE0BzoMENAV1iGcV7AuSppO ke76zCQLA9wvzKVYja55L5eOJ31a26gvn0LqVEfc8HhbXsSHGN2mgGy0YZhzLd3Y +Sf+9EQCGo6/nHemgUrMz+0UcLSA8KzjLCLk96jQepDn4yBH8akK4sVH1sLvwBSI tfuWT15PFW1iFY66rHebRt4hHxpEGj831k5t/l38nFMbGIC9kAOXdkVqQhk1kHo= =jxGe -----END PGP SIGNATURE----- --------------enig0F439D4F6D09063EF4FD33EA--