From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuefM-00071x-R4 for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuefH-0002VF-7I for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:08:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuefG-0002Ut-VJ for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:08:47 -0400 Message-ID: <50123E79.2070106@redhat.com> Date: Fri, 27 Jul 2012 09:08:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <87ipdacrhj.fsf@codemonkey.ws> <5011AB96.7070405@redhat.com> In-Reply-To: <5011AB96.7070405@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Plan for error handling in QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Luiz Capitulino , qemu-devel@nongnu.org, anthony@codemonkey.ws, Markus Armbruster Il 26/07/2012 22:41, Eric Blake ha scritto: >> > 5. The following errors are used by libvirt: >> > - CommandNotFound: QMP parsing >> > - DeviceNotActive/KVMMissingCap: ballooning >> > - DeviceNotFound: drive_del >> > - MigrationExpected: cont > DeviceInUse, NotSupported: block-stream > > Search for qemuMonitorJSONHasError in src/qemu/qemu_monitor_json.c > These are only used for better error messages. We can tolerate a brief reduction in error message quality for now, in the meanwhile libvirt can prepare to use the free-form messages for QEMU. Having free-form error messages will also help with internationalization. Paolo