From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores
Date: Fri, 27 Jul 2012 13:10:47 +0200 [thread overview]
Message-ID: <50127737.7020200@suse.de> (raw)
In-Reply-To: <1343233543-18561-3-git-send-email-aliguori@us.ibm.com>
Am 25.07.2012 18:25, schrieb Anthony Liguori:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> qemu-config.c | 38 +++++++++++++++++++-------------------
> 1 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/qemu-config.c b/qemu-config.c
> index 5c3296b..1616547 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
[...]
> @@ -560,11 +560,11 @@ static QemuOptsList qemu_machine_opts = {
> .type = QEMU_OPT_STRING,
> .help = "accelerator list",
> }, {
> - .name = "kernel_irqchip",
> + .name = "kernel-irqchip",
> .type = QEMU_OPT_BOOL,
> .help = "use KVM in-kernel irqchip",
> }, {
> - .name = "kvm_shadow_mem",
> + .name = "kvm_shadow-mem",
Was the remaining underscore an oversight or intentional?
> .type = QEMU_OPT_SIZE,
> .help = "KVM shadow MMU size",
> }, {
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-27 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 16:25 [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts Anthony Liguori
2012-07-25 16:25 ` [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names Anthony Liguori
2012-07-25 16:45 ` Eric Blake
2012-07-25 16:46 ` Eric Blake
2012-07-25 17:34 ` Anthony Liguori
2012-07-25 16:53 ` Peter Maydell
2012-07-25 17:33 ` Anthony Liguori
2012-07-25 18:31 ` Peter Maydell
2012-07-27 7:44 ` Markus Armbruster
2012-07-27 11:14 ` Peter Maydell
2012-07-25 16:25 ` [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores Anthony Liguori
2012-07-25 17:32 ` Luiz Capitulino
2012-07-25 18:20 ` Anthony Liguori
2012-07-25 18:58 ` Peter Maydell
2012-07-25 19:02 ` Luiz Capitulino
2012-07-25 19:02 ` Peter Maydell
2012-07-25 19:09 ` [Qemu-devel] Changing qemu's -help output Luiz Capitulino
2012-07-25 21:21 ` [Qemu-devel] [libvirt] " Eric Blake
2012-07-27 7:45 ` [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores Markus Armbruster
2012-07-27 11:10 ` Andreas Färber [this message]
2012-07-25 17:34 ` [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts Luiz Capitulino
2012-07-27 8:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50127737.7020200@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).