From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SumRj-0006vI-9Z for qemu-devel@nongnu.org; Fri, 27 Jul 2012 11:27:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SumRe-0008Dw-T2 for qemu-devel@nongnu.org; Fri, 27 Jul 2012 11:27:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SumRe-00088n-8K for qemu-devel@nongnu.org; Fri, 27 Jul 2012 11:27:14 -0400 Message-ID: <5012B341.2080709@redhat.com> Date: Fri, 27 Jul 2012 09:26:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-34-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-34-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE0EEC013965A548809388B03" Subject: Re: [Qemu-devel] [PATCH 33/47] mirror: add support for on-source-error/on-target-error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE0EEC013965A548809388B03 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > Error management is important for mirroring; otherwise, an error on the= > target (even something as "innocent" as ENOSPC) requires to start again= > with a full copy. Similar to on_read_error/on_write_error, two separat= e > knobs are provided for on_source_error (reads) and on_target_error (wri= tes). > The default is 'report' for both. >=20 > The 'ignore' policy will leave the sector dirty, so that it will be > retried later. Thus, it will not cause corruption. How frequently will the dirty sector be retried when the policy is 'ignore'? Are we going to be causing a denial-of-service by repeatedly retrying the sector until the user does something about the error event? > +++ b/qapi-schema.json > @@ -1389,17 +1389,27 @@ > # (all the disk, only the sectors allocated in the topmost imag= e, or > # only new I/O). > # > +# @on-source-error: #optional the action to take on an error on the so= urce, > +# default 'report'. 'stop' and 'enospc' can only be= used > +# if the block device supports io-status (see BlockI= nfo). > +# > +# @on-target-error: #optional the action to take on an error on the ta= rget, > +# default 'report' (no limitations, since this appli= es to > +# a different block device than @device). > +# > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > # If @target can't be opened, OpenFileFailed > # If @format is invalid, InvalidBlockFormat > +# If @on_source_error is not supported, InvalidParameter s/_/-/g --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE0EEC013965A548809388B03 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQErNCAAoJEKeha0olJ0NqsZkH/iuYpcWCXZXA6XolPacn8m12 sIfy+8FTCMV71udG+98mpiZRMD4fM+6MR6qj0U9CMt9/+W7xjgMfPOhQrsbJcOl5 /hOkiHg5cDQpFlFZONsTyMnXhHSiola+9XUMl9iGI7R3vmcezWE1OElH1vU/jyLB fHKtvk0Wm3BeXHkUVF/iyMu9tYEhiAhqegomfH2MsVamyGxRZpXLQawNjXSzY+Co QHgHIG71MLw6ffef4n1yPOef0eu/+qk0EwMkgLS5E8iN68QyyP9ravrupR9oZFk8 fiw+JQVuDF14Q4J7PImOtbMgELmlROgBqUT22/Ob/NIong706sNQYc6ChwV62Rk= =DhR9 -----END PGP SIGNATURE----- --------------enigE0EEC013965A548809388B03--