From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sun2Q-0002bX-MA for qemu-devel@nongnu.org; Fri, 27 Jul 2012 12:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sun2P-00059i-Bp for qemu-devel@nongnu.org; Fri, 27 Jul 2012 12:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sun2P-00059c-2B for qemu-devel@nongnu.org; Fri, 27 Jul 2012 12:05:13 -0400 Message-ID: <5012BC2F.6080607@redhat.com> Date: Fri, 27 Jul 2012 10:05:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-37-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-37-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2625E5F457E589AB6587A44E" Subject: Re: [Qemu-devel] [PATCH 36/47] host-utils: add ffsl and flsl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2625E5F457E589AB6587A44E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > We can provide fast versions based on the other functions defined > by host-utils.h. Some care is required on glibc, which provides > ffsl already. >=20 > Signed-off-by: Paolo Bonzini > --- > host-utils.h | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > +#ifdef __GLIBC__ > +#define ffsl qemu_ffsl > +#endif > +static inline int ffsl(long val) ffsl() makes sense in comparison to the standardized ffs() (why POSIX doesn't specify one is beyond me). > + > +static inline int flsl(long val) But what good is flsl (I'm assuming you mean find-last-set, or the most-significant set bit), especially since there is no standardized fls() and no fls() in host-utils.h? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2625E5F457E589AB6587A44E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQErw0AAoJEKeha0olJ0NqTDUIAIO1C7LlV8k39PKW06kXnajV IqlFf5UH3aS9g6HUTReQBxF3H20CApYFZHrL9QM64rMBMCML/7tM1ZbE5MNsQUTd urq/owcdeeb4xxGOcF89M9x0Yvj/7IE8XC2xEhHTmNRGQiofQRoZmK71j54aKLPD KSLUAcdp/+lLEYk5e4TVWoUOZ/9g1/eocDm6qGA7IybTJHJ9VvehWnK7pJqQfoYG O+Bj4GKfZXSoBz+5eR8+gXusrly71Z4acMALHKiqNoovvZR04rkflsKL4N73JMa6 babQUOTxIxkAG+GonAhDo42BvgWrxa5O/FLWarrVkUwBkrIlSdlcIwBwDGtUzsw= =zkKR -----END PGP SIGNATURE----- --------------enig2625E5F457E589AB6587A44E--