From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv7Mq-0000Lu-OE for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:47:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sv7Mp-0005He-J3 for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:47:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv7Mp-0005HX-9P for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:47:39 -0400 Message-ID: <5013ED3B.5050808@redhat.com> Date: Sat, 28 Jul 2012 07:46:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-45-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-45-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig237BEC60774E36B75E316F1A" Subject: Re: [Qemu-devel] [PATCH 44/47] mirror: switch mirror_iteration to AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig237BEC60774E36B75E316F1A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > There is really no change in the behavior of the job here, since there > is still a maximum of one in-flight I/O operation between the source an= d > the target. However, this patch already introduces moves the copy logi= c grammar: 'already introduces moves' is awkward, but I'm not sure what you meant. > from mirror_iteration to AIO callbacks; it also adds the logic to count= > in-flight operations, and only complete the job after they have finishe= d. s/complete/completes/ >=20 > Some care is required in the error and cancellation cases, in order > to avoid access to dangling pointers (and consequent corruption). >=20 > Signed-off-by: Paolo Bonzini > --- > block/mirror.c | 161 ++++++++++++++++++++++++++++++++++++++++++------= -------- > trace-events | 2 + > 2 files changed, 123 insertions(+), 40 deletions(-) >=20 > diff --git a/block/mirror.c b/block/mirror.c > index 81a600b..971c923 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -17,7 +17,7 @@ > #include "qemu/ratelimit.h" > #include "bitmap.h" > =20 > -#define SLICE_TIME 100000000ULL /* ns */ > +#define SLICE_TIME 100000000ULL /* ns */ Why the spurious respacing? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig237BEC60774E36B75E316F1A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQE+08AAoJEKeha0olJ0NqCgIIAIsA5vBrSltCP8QsOGM5MUKz XpHvQVdeVLhxypZxNe3HA5LMpgrWUGiGGeLzOT35ceRjxr2iboHjdvFMvzWmM1EQ 03d/R/nSA6jBaJccLAIEIt5M8uroRhi3t7xS3xnftpWYJy4eaF5znwnUr9sZcToW 2TXqYmmq4X2+FWwKxuo7SeNnhVkHQDTO4fQ7kdK2RDoAiI8RcWjqORMRfIuu2/Fz 3+s+Uizuzh8we4n7I12EoH3zdIv8YArkv4As5PCFxLjiRvP8mT6SeextbczAXlje cZcx/rRP4Cgvzus30I7NpKGxpECwJimy0Z9ClhM0w/tVPRW2/jLvHE3IUi/f2y0= =ailo -----END PGP SIGNATURE----- --------------enig237BEC60774E36B75E316F1A--