From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SvT4o-0006vq-Sp
	for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:58:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SvT4n-00020Z-8X
	for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:58:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SvT4n-00020T-0P
	for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:58:29 -0400
Message-ID: <50153369.3030005@redhat.com>
Date: Sun, 29 Jul 2012 15:58:17 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1342794882-30648-1-git-send-email-anthony.perard@citrix.com>
	<1342794882-30648-4-git-send-email-anthony.perard@citrix.com>
In-Reply-To: <1342794882-30648-4-git-send-email-anthony.perard@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 3/5] exec: Introduce helper to set dirty
	flags.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Xen Devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, QEMU-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 07/20/2012 05:34 PM, Anthony PERARD wrote:
> This new helper/hook is used in the next patch to add an extra call in a single
> place.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  exec.c |   42 ++++++++++++++----------------------------
>  1 files changed, 14 insertions(+), 28 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index feb4795..b24a03a 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3386,6 +3386,16 @@ int cpu_memory_rw_debug(CPUArchState *env, target_ulong addr,
>  }
>  
>  #else

<blank line>

> +static void set_dirty_helper(target_phys_addr_t addr, target_phys_addr_t length)

More meaningful name please.  Practically every function can be name
something_helper().

> +{
> +    if (!cpu_physical_memory_is_dirty(addr)) {
> +        /* invalidate code */
> +        tb_invalidate_phys_page_range(addr, addr + length, 0);
> +        /* set dirty bit */
> +        cpu_physical_memory_set_dirty_flags(addr, (0xff & ~CODE_DIRTY_FLAG));
> +    }
> +}
> +

Otherwise looks good; a nice cleanup in its own right.



-- 
error compiling committee.c: too many arguments to function