From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-ppc <qemu-ppc@nongnu.org>,
anthony@codemonkey.ws, Scott Wood <scottwood@freescale.com>,
liwanp@linux.vnet.ibm.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges
Date: Mon, 30 Jul 2012 01:08:04 +0200 [thread overview]
Message-ID: <5015C254.3090508@suse.de> (raw)
In-Reply-To: <20120729122207.GD15558@redhat.com>
Am 29.07.2012 14:22, schrieb Michael S. Tsirkin:
> On Thu, Jul 26, 2012 at 02:28:32PM +0200, Andreas Färber wrote:
>> Uglify the parent field to enforce QOM-style access via casts.
>> Don't just typedef PCIHostState, either use it directly or embed it.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> I already said I don't see the point of this change. [...]
You did, and still Anthony instructed me otherwise. Please discuss that
with him, thanks.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-29 23:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 12:28 [Qemu-devel] [PATCH v4 00/18] pci_host: Convert to QOM Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 01/18] pci: Make host bridge TypeInfos const Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 02/18] alpha_typhoon: QOM'ify Typhoon PCI host bridge Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 03/18] bonito: QOM'ify Bonito " Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 04/18] dec_pci: QOM'ify DEC 21154 PCI-PCI bridge Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 05/18] grackle_pci: QOM'ify Grackle PCI host bridge Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 06/18] gt64xxx: QOM'ify GT64120 " Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 07/18] ppc4xx_pci: QOM'ify ppc4xx " Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 08/18] ppce500_pci: QOM'ify e500 " Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 09/18] prep_pci: QOM'ify Raven " Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 10/18] spapr_pci: QOM'ify sPAPR " Andreas Färber
2012-07-26 12:31 ` David Gibson
2012-07-26 13:03 ` Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 11/18] unin_pci: QOM'ify UniNorth PCI host bridges Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 12/18] pci_host: Turn into SysBus-derived QOM type Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 13/18] pci: Derive PCI host bridges from TYPE_PCI_HOST_BRIDGE Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges Andreas Färber
2012-07-29 12:22 ` Michael S. Tsirkin
2012-07-29 23:08 ` Andreas Färber [this message]
2012-07-30 16:07 ` Anthony Liguori
2012-07-30 16:13 ` Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH RFC v4 15/18] MAINTAINERS: Document sPAPR (pSeries) machine Andreas Färber
2012-07-26 12:31 ` David Gibson
2012-07-26 12:28 ` [Qemu-devel] [PATCH RFC v4 16/18] MAINTAINERS: Document e500 machine Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH RFC v4 17/18] MAINTAINERS: Document Bamboo machine Andreas Färber
2012-07-26 12:28 ` [Qemu-devel] [PATCH RFC v4 18/18] MAINTAINERS: Document virtex_ml507 machine Andreas Färber
2012-07-27 17:42 ` Edgar E. Iglesias
2012-07-28 17:23 ` Andreas Färber
2012-07-28 21:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5015C254.3090508@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=david@gibson.dropbear.id.au \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).