From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svcax-0006bY-Kn for qemu-devel@nongnu.org; Sun, 29 Jul 2012 19:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Svcaw-000589-Jt for qemu-devel@nongnu.org; Sun, 29 Jul 2012 19:08:19 -0400 Message-ID: <5015C254.3090508@suse.de> Date: Mon, 30 Jul 2012 01:08:04 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1343305716-5178-1-git-send-email-afaerber@suse.de> <1343305716-5178-15-git-send-email-afaerber@suse.de> <20120729122207.GD15558@redhat.com> In-Reply-To: <20120729122207.GD15558@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Alexander Graf , qemu-ppc , anthony@codemonkey.ws, Scott Wood , liwanp@linux.vnet.ibm.com, David Gibson Am 29.07.2012 14:22, schrieb Michael S. Tsirkin: > On Thu, Jul 26, 2012 at 02:28:32PM +0200, Andreas F=E4rber wrote: >> Uglify the parent field to enforce QOM-style access via casts. >> Don't just typedef PCIHostState, either use it directly or embed it. >> >> Signed-off-by: Andreas F=E4rber >=20 > I already said I don't see the point of this change. [...] You did, and still Anthony instructed me otherwise. Please discuss that with him, thanks. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg