[Qemu-devel] [PATCH] SCSI update to the correct sense code for media removal prevention

[Qemu-devel] [PATCH] SCSI update to the correct sense code for media removal prevention

[Ronnie Sahlberg]

List, Paolo

Please find a trivial patch that changes the sense code for errors when trying, and failing, to eject media using the START_STOP_UNIT command when the medium is locked down by a previous PREVENT_ALLOW_MEDIUM_REMOVAL command.

MMC Annex F lists MEDIUM_REMOVAL_PREVENTED as the recommended sense code for this error.


This now passes the test that a SCSI target retports the corre3ct sense code(s) for medium removal protection :

iscsi-test --dataloss --test="*prevent*eject*" iscsi://127.0.0.1:32601/iqn.qemu.scsi-test/3
0381_preventallow_eject:
========================
Try to set PREVENTALLOW ... [OK]
Try to eject the media ... Eject failed. [OK]
Load the media again in case it was ejected ... [OK]
Clear the PREVENTALLOW again ... [OK]
TEST T0381_preventallow_eject [OK]


regards
ronnie sahlberg

[Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors

[Ronnie Sahlberg]

Change the sense codes for failures to eject a device that is locked
by PREVENT_ALLOW_MEDIUM_REMOVAL from
the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
MEDIUM_REMOVAL_PREVENTED.

The second sense code is more accurate, and is also listed in MMC annex F
for the recommended sense codes for MMC devices while the first sense code is not.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
---
 hw/scsi-bus.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index dc74063..9929d3c 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1089,7 +1089,7 @@ const struct SCSISense sense_code_NO_MEDIUM = {
 
 /* LUN not ready, medium removal prevented */
 const struct SCSISense sense_code_NOT_READY_REMOVAL_PREVENTED = {
-    .key = NOT_READY, .asc = 0x53, .ascq = 0x00
+    .key = NOT_READY, .asc = 0x53, .ascq = 0x02
 };
 
 /* Hardware error, internal target failure */
@@ -1129,7 +1129,7 @@ const struct SCSISense sense_code_INCOMPATIBLE_FORMAT = {
 
 /* Illegal request, medium removal prevented */
 const struct SCSISense sense_code_ILLEGAL_REQ_REMOVAL_PREVENTED = {
-    .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x00
+    .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x02
 };
 
 /* Command aborted, I/O process terminated */
-- 
1.7.3.1

Re: [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors

[Paolo Bonzini]

Il 29/07/2012 23:52, Ronnie Sahlberg ha scritto:
> Change the sense codes for failures to eject a device that is locked
> by PREVENT_ALLOW_MEDIUM_REMOVAL from
> the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
> MEDIUM_REMOVAL_PREVENTED.
> 
> The second sense code is more accurate, and is also listed in MMC annex F
> for the recommended sense codes for MMC devices while the first sense code is not.
> 
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  hw/scsi-bus.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.  Can you redo these two MMC patches also for ATAPI?

Paolo