From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SvmyZ-0006Sl-AF
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 06:13:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SvmyT-0004Hd-Is
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 06:13:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34457)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SvmyT-0004HY-B8
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 06:13:17 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6UADGmB004069
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 30 Jul 2012 06:13:16 -0400
Message-ID: <50165F83.6030701@redhat.com>
Date: Mon, 30 Jul 2012 12:18:43 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1343555755-4122-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1343555755-4122-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid
 parameters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 07/29/2012 11:55 AM, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>   hw/qxl.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index 92e985b..5278541 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -1405,6 +1405,18 @@ async_common:
>           QXLCookie *cookie = NULL;
>           QXLRect update = d->ram->update_area;
>
> +        if (d->ram->update_surface > NUM_SURFACES) {
> +            qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n",
> +                              d->ram->update_surface);
> +            return;
> +        }
> +        if (update.left >= update.right || update.top >= update.bottom) {
> +            qxl_set_guest_bug(d,
> +                    "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n",
> +                    update.left, update.top, update.right, update.bottom);
> +            return;
> +        }
> +
>           if (async == QXL_ASYNC) {
>               cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO,
>                                       QXL_IO_UPDATE_AREA_ASYNC);
>