From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SvqOF-00050P-Ev
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 09:52:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SvqOA-0003RX-88
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 09:52:07 -0400
Message-ID: <5016917E.9080109@suse.de>
Date: Mon, 30 Jul 2012 15:51:58 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1342724013-1633-1-git-send-email-minyard@acm.org>
	<1342724013-1633-11-git-send-email-minyard@acm.org>
In-Reply-To: <1342724013-1633-11-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 10/18] qom: release previous object when
 setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, Anthony Liguori <anthony@codemonkey.ws>
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Am 19.07.2012 20:53, schrieb minyard@acm.org:
> From: Corey Minyard <cminyard@mvista.com>
>=20
> When setting an object, if you don't release the previous object
> that was there, it may become unusable.  This change allows a
> chardev to be removed from one object's properties and added to
> another's.
>=20
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Anthony, this looks like a valid and generic QOM memory leak fix to me.
Suggesting to cherry-pick this patch to master and stable-1.1.

Andreas

> ---
>  qom/object.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>=20
> diff --git a/qom/object.c b/qom/object.c
> index 00bb3b0..f0ff9cc 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -731,6 +731,9 @@ void object_property_set(Object *obj, Visitor *v, c=
onst char *name,
>      if (!prop->set) {
>          error_set(errp, QERR_PERMISSION_DENIED);
>      } else {
> +        if (prop->release) {
> +            prop->release(obj, name, prop->opaque);
> +        }
>          prop->set(obj, v, prop->opaque, name, errp);
>      }
>  }
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg