qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corey Minyard <tcminyard@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Corey Minyard <tcminyard@gmail.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Third shot at adding IPMI to qemu
Date: Mon, 30 Jul 2012 10:17:59 -0500	[thread overview]
Message-ID: <5016A5A7.1090004@acm.org> (raw)
In-Reply-To: <50169494.6050004@suse.de>

On 07/30/2012 09:05 AM, Andreas Färber wrote:
> Am 30.07.2012 15:34, schrieb Corey Minyard:
>> I haven't heard anything on this.
> FWIW you did hear from Paolo. :)

Yes, I did, I apologize.  I think I meant to say "recently".

>> Any comments or movement on this set
>> of patches?
> For a third shot, you should've used --subject-prefix="PATCH v3" so that
> each patch becomes distinguishable on Patchwork, in inbox searches, etc.
>
> http://wiki.qemu.org/Contribute/SubmitAPatch

Ok.

>
> I've started commenting on some non-functional code issues that you
> should review throughout the series. It seems in lack of how-tos you
> have oriented yourself on some "old-style" devices, would be nice to
> update that for v4 as anti-typo measure and to increase chances of
> people copying a modern device. ;)

Yes, I copied the serial driver, mostly, which has probably been around 
a while.

Thank you,

-corey

  reply	other threads:[~2012-07-30 15:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 18:53 [Qemu-devel] Third shot at adding IPMI to qemu minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry minyard
2012-07-30 15:37   ` Anthony Liguori
2012-07-30 16:44     ` Corey Minyard
2012-07-30 17:25       ` Anthony Liguori
2012-07-30 17:40         ` Corey Minyard
2012-08-02  1:15         ` Kevin O'Connor
2012-08-02  2:11           ` Corey Minyard
2012-08-02  2:40             ` Anthony Liguori
2012-08-02 12:17               ` Corey Minyard
2012-08-02 18:32                 ` Anthony Liguori
2012-08-02 19:20                   ` Corey Minyard
2012-08-02 21:05                     ` Anthony Liguori
2012-08-06 15:38                       ` Corey Minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 02/18] pc: move SMBIOS setup to after device init minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 03/18] vl: Move init_timer_alarm() earlier minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 04/18] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 05/18] qemu-char: Allow a chardev to reconnect if disconnected minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 06/18] qemu-char: Fix a race reporting opens and closes minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 07/18] qemu-char: remove free of chr from win_stdio_close minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 08/18] qemu-char: Close fd at end of file minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 09/18] qdev: Add a pre-firmware init capability minyard
2012-07-30 14:36   ` Andreas Färber
2012-07-30 15:27     ` Corey Minyard
2012-07-30 15:40   ` Anthony Liguori
2012-07-19 18:53 ` [Qemu-devel] [PATCH 10/18] qom: release previous object when setting minyard
2012-07-30 13:51   ` Andreas Färber
2012-09-10 14:34     ` Andreas Färber
2012-07-19 18:53 ` [Qemu-devel] [PATCH 11/18] Add a base IPMI interface minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 12/18] IPMI: Add a PC ISA type structure minyard
2012-07-30 13:45   ` Andreas Färber
2012-07-30 17:09     ` Corey Minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 13/18] IPMI: Add a KCS low-level interface minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 14/18] IPMI: Add a BT " minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 15/18] IPMI: Add a local BMC simulation minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 16/18] IPMI: Add an external connection simulation interface minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 17/18] IPMI: Add tests minyard
2012-07-19 18:53 ` [Qemu-devel] [PATCH 18/18] IPMI: Add documentation minyard
2012-07-20  6:48 ` [Qemu-devel] Third shot at adding IPMI to qemu Paolo Bonzini
2012-07-30 13:34 ` Corey Minyard
2012-07-30 14:05   ` Andreas Färber
2012-07-30 15:17     ` Corey Minyard [this message]
2012-09-10 14:48 ` Andreas Färber
2012-09-10 16:52   ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5016A5A7.1090004@acm.org \
    --to=tcminyard@gmail.com \
    --cc=afaerber@suse.de \
    --cc=minyard@acm.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).