From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svt9P-0008W2-Q4 for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Svt9O-0001lS-HM for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:48:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svt9O-0001lL-9D for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:48:58 -0400 Message-ID: <5016BAF1.8020302@redhat.com> Date: Mon, 30 Jul 2012 10:48:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343308701-29632-1-git-send-email-benoit@irqsave.net> <1343308701-29632-3-git-send-email-benoit@irqsave.net> <20120730133229.5b43f402@doriath.home> In-Reply-To: <20120730133229.5b43f402@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig95B66B63000F22317F4255C5" Subject: Re: [Qemu-devel] [PATCH V5 2/4] block: Use bdrv_get_backing_file_depth() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, benoit.canet@gmail.com, =?ISO-8859-1?Q?Beno=EEt_Canet?= , qemu-devel@nongnu.org, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig95B66B63000F22317F4255C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/30/2012 10:32 AM, Luiz Capitulino wrote: > On Thu, 26 Jul 2012 15:18:19 +0200 > benoit.canet@gmail.com wrote: >=20 >> From: Beno=EEt Canet >> >> Use the dedicated counting function in qmp_query_block in order to >> propagate the backing file depth to HMP. >> >> Signed-off-by: Benoit Canet >> +++ b/qapi-schema.json >> @@ -398,6 +398,8 @@ >> # >> # @backing_file: #optional the name of the backing file (for copy-on-= write) >> # >> +# @backing_file_depth: number of files in the backing file chain (sin= ce: 1.2) >> +# >> # @encrypted: true if the backing device is encrypted >> # >> # @bps: total throughput limit in bytes per second is specified >> @@ -418,9 +420,10 @@ >> ## >> { 'type': 'BlockDeviceInfo', >> 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', >> - '*backing_file': 'str', 'encrypted': 'bool', >> - 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int', >> - 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} } >> + '*backing_file': 'str', 'backing-file-depth': 'int', >=20 > Should use underscores, ie. should be backing_file_depth. Really? I thought we _want_ new interfaces to use '-', not '_', in QMP. For 'backing_file', we are stuck due to back-compat (unless Anthony's proposed patch to parse names case-insensitively with '-' and '_' folded together is taken), but for the new field, we have no back-compat constraints, and I would prefer backing-file-depth. At any rate, you definitely need to make sure you agree between the docs above and the JSON statement below (as written, you have both spellings in the same patch). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig95B66B63000F22317F4255C5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQFrryAAoJEKeha0olJ0NqxNYH/iYqlAHoCF5A9yTD9PuQgKS+ LB56tskWF2vvXvkNtbtSTz5hpaxW92XqWsvCVKIUHj3oBuJjArDIDzxLR5HU+Y/6 Ei3XM0gz0glSoz1hf0NtHsX5LqlBFH93XfflbRaJZYz8vvjBMKkElj9+8wseVUO3 +cOk+IklRd6nrdKDx0/t/IddiNFxKckCkvyVxGVYnzkeed8lFyLxod/7QKdX2nk7 saqHfOZbN5nMlYy5tNTA+tq6tTQ7XQD67I+krcm6wSJ+j9Ggpa58qFAbP2MRiecI IN+ZSICmYb9pMprwoEvLdmPFEurXq9YBelNv3wNA9ZZpRHI0cRo0Ml241VnC9ns= =DgLH -----END PGP SIGNATURE----- --------------enig95B66B63000F22317F4255C5--