From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60595)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SvtTO-00059i-Kg
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:09:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SvtTN-000189-If
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:09:38 -0400
Received: from mail-qc0-f173.google.com ([209.85.216.173]:60134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SvtTN-000181-Db
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:09:37 -0400
Received: by qcab12 with SMTP id b12so2935966qca.4
	for <qemu-devel@nongnu.org>; Mon, 30 Jul 2012 10:09:37 -0700 (PDT)
Message-ID: <5016BFCB.9000505@acm.org>
Date: Mon, 30 Jul 2012 12:09:31 -0500
From: Corey Minyard <tcminyard@gmail.com>
MIME-Version: 1.0
References: <1342724013-1633-1-git-send-email-minyard@acm.org>
	<1342724013-1633-13-git-send-email-minyard@acm.org>
	<5016900F.2000504@suse.de>
In-Reply-To: <5016900F.2000504@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 12/18] IPMI: Add a PC ISA type structure
Reply-To: minyard@acm.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>


On 07/30/2012 08:45 AM, Andreas Färber wrote:
> Am 19.07.2012 20:53, schrieb minyard@acm.org:
>> From: Corey Minyard <cminyard@mvista.com>
>>
>> +
>> +static Property ipmi_isa_properties[] = {
>> +    DEFINE_PROP_STRING("interface", ISAIPMIDevice, interface),
>> +    DEFINE_PROP_HEX32("iobase", ISAIPMIDevice, iobase,  0),
>> +    DEFINE_PROP_UINT32("irq",   ISAIPMIDevice, isairq,  5),
>> +    DEFINE_PROP_UINT8("slave_addr", ISAIPMIDevice, slave_addr,  0),
>> +    DEFINE_PROP_CHR("chardev",  ISAIPMIDevice, chr),
>> +    DEFINE_PROP_END_OF_LIST(),
>> +};
>> +
>> +#if 0 /* FIXME */
> Fix this? x86 machines should definitely remain migratable.

Yeah, I need to fix that so it works.  I'll definitely get that in 
before the next iteration.

>> +static const VMStateDescription vmstate_isa_ipmi = {
>> +    .name = "isa-ipmi",
>> +    .version_id = 3,
>> +    .minimum_version_id = 3,
>> +    .fields      = (VMStateField[]) {
>> +        /* FIXME - fill this in */
>> +        VMSTATE_END_OF_LIST()
>> +    }
>> +};
>> +#endif
>> +
>> +static void ipmi_isa_class_initfn(ObjectClass *klass, void *data)
>> +{
>> +    DeviceClass *dc = DEVICE_CLASS(klass);
>> +    ISADeviceClass *ic = ISA_DEVICE_CLASS(klass);
>> +    ic->init = ipmi_isa_initfn;
>> +    dc->reset = ipmi_isa_reset;
>> +    /* dc->vmsd = &vmstate_isa_ipmi; FIXME */
>> +    dc->props = ipmi_isa_properties;
>> +}
>> +
>> +static TypeInfo ipmi_isa_info = {
> static const please.
>
>> +    .name          = "isa-ipmi",
> Where is this used? Should probably be TYPE_..., too.

That's what the user specified on the -device line.  Does it need to be 
referenced someplace else?

Thanks,

-corey