From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svtxh-0004sd-U3 for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:40:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Svtxd-0005aJ-0a for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:40:57 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:64345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svtxc-0005aB-Ri for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:40:52 -0400 Received: by obbta14 with SMTP id ta14so8804101obb.4 for ; Mon, 30 Jul 2012 10:40:52 -0700 (PDT) Message-ID: <5016C71E.9020206@acm.org> Date: Mon, 30 Jul 2012 12:40:46 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1342724013-1633-1-git-send-email-minyard@acm.org> <1342724013-1633-2-git-send-email-minyard@acm.org> <87obmxxntb.fsf@codemonkey.ws> <5016B9D2.2010401@mvista.com> <87sjc917r7.fsf@codemonkey.ws> In-Reply-To: <87sjc917r7.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Corey Minyard , qemu-devel@nongnu.org On 07/30/2012 12:25 PM, Anthony Liguori wrote: > Corey Minyard writes: > >> On 07/30/2012 10:37 AM, Anthony Liguori wrote: >>> minyard@acm.org writes: >>> >>>> From: Corey Minyard >>>> >>>> There was no way to directly add a table entry to the SMBIOS table, >>>> even though the BIOS supports this. So add a function to do this. >>>> This is in preparation for the IPMI handler adding it's SMBIOS table >>>> entry. >>>> >>>> Signed-off-by: Corey Minyard >>> I don't expect that hardware ever adds SMBIOS entries. Rather, the BIOS >>> adds the entries by probing the hardware. >> Well, memory entries are added by QEMU, why not let the BIOS probe for >> that? > QEMU doesn't add any entries by default. SeaBIOS owns SMBIOS. QEMU > uses a backchannel to hand SeaBIOS tables that SeaBIOS can then expose. > The reason we use a table based interface is because type 0 and type 1 > tables can have vendor extensions that are in a vendor specific format. > > But SeaBIOS unquestionably owns SMBIOS generation. > >> Plus, I really doubt that BIOSes on real systems probe for this. >> I'd guess they are hard-coded. > I think you'd be surprised how little is hard coded on modern BIOSes. > >>> So I think you should solve this in SeaBIOS, instead of trying to do it >>> in QEMU. I think that also solves the problem you have with >>> pre-firmware init. >> The user can pass the I/O base and IRQ values in on the QEMU command >> line, and they can be arbitrary values. The BIOS is not going to be >> able to probe for those. > Then pass the information that the BIOS needs through fw_cfg. That's > what it's there for. Ok, I understand. Thanks, I'll look at doing it this way. -corey