From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svu2X-0006w9-7m for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:46:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Svu2V-0007jA-EK for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:45:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Svu2V-0007ic-5l for qemu-devel@nongnu.org; Mon, 30 Jul 2012 13:45:55 -0400 Message-ID: <5016C84C.5060704@redhat.com> Date: Mon, 30 Jul 2012 11:45:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343554983-4195-1-git-send-email-owasserm@redhat.com> <1343554983-4195-2-git-send-email-owasserm@redhat.com> In-Reply-To: <1343554983-4195-2-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigEEF2E109BC44B707948984DF" Subject: Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEEF2E109BC44B707948984DF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/29/2012 03:42 AM, Orit Wasserman wrote: > Add migration capabilities that can be queried by the management. > The management can query the source QEMU and the destination QEMU in or= der to > verify both support some migration capability (currently only XBZRLE). >=20 > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > +++ b/qapi-schema.json > @@ -306,6 +306,45 @@ > { 'command': 'query-migrate', 'returns': 'MigrationInfo' } > =20 > ## > +# @MigrationCapability > +# > +# Migration capabilities enumeration > +# > +# @xbzrle: Migration supports xbzrle (Xor Based Zero Length Encoding).= In patch 3/10, you named it: XBZRLE (Xor Based Zero Run Length Encoding) You are missing 'Run' here. > +# This feature allows us to minimize migration traffic for ce= rtain work > +# loads, by sending compressed difference of the pages > +# > +# Since: 1.2 We are inconsistent on whether this should be 'Since: 1.2.0' or 'Since: 1.2', but cleaning that up would be an independent patch since there are pre-existing uses of both forms. Other than that, Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigEEF2E109BC44B707948984DF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQFshMAAoJEKeha0olJ0NqTg4H/RHe7zBvAiL+IoJzTiH9Ye75 ImETAWt4FprC1pWFqFv+8OH+0luI/SodSI2Cz6k6LmvIlXj+E1iCNXnN+uAiKk2H OvQRAS57E/gc5raL7GygP5mzdbCqTlNs3mMLJyp9iU2mnJieI9x9ZLDi58hBvByz nGwrBWRPGSEcKnvr9vfCVyrn3ItvPGluySF4uZ4mT2xdFIJwJdiV6xfBwCSvwlo/ xh5jP81tBKmIOsncuwsPI2yQ1SdPrUjEELDPzM9/8SZCUJJRWt0P9eIN86bd8o9u dwTJj0LfiJib95wMYS6zj++crOOQyXJve5F93ClF+n3viwoxuyOd4okd5pell9Y= =lYjw -----END PGP SIGNATURE----- --------------enigEEF2E109BC44B707948984DF--