From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvuRs-0002dr-R6 for qemu-devel@nongnu.org; Mon, 30 Jul 2012 14:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvuRr-00032x-LA for qemu-devel@nongnu.org; Mon, 30 Jul 2012 14:12:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvuRr-00031p-Cp for qemu-devel@nongnu.org; Mon, 30 Jul 2012 14:12:07 -0400 Message-ID: <5016CE68.3050802@redhat.com> Date: Mon, 30 Jul 2012 12:11:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343554983-4195-1-git-send-email-owasserm@redhat.com> <1343554983-4195-3-git-send-email-owasserm@redhat.com> In-Reply-To: <1343554983-4195-3-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA34854CA3DBDE6E66061C75B" Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA34854CA3DBDE6E66061C75B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/29/2012 03:42 AM, Orit Wasserman wrote: > The management can enable/disable a capability for the next migration b= y using > migrate_set_parameter command. > The management can query the current migration capabilities using > query-migrate-parameters In addition to Luiz' nitpicks: Here in the commit message, you are mixing HMP (migrate_set_parameter) with QMP (query-migrate-parameters). It might be better to stick to HMP only (migrate_set_parameter, info migrate_parameters) or QMP only (migrate-set-parameter, query-migrate-parameters), or even list the spellings for both protocols. > +++ b/hmp-commands.hx > @@ -1419,6 +1433,8 @@ show user network stack connection states > show migration status > @item info migration_capabilities > show migration capabilities > +@item info migrate_parameters > +show current migration parameters > +++ b/monitor.c > @@ -2669,6 +2669,13 @@ static mon_cmd_t info_cmds[] =3D { > .mhandler.info =3D hmp_info_migration_capabilities, > }, > { > + .name =3D "migrate-parameters", Is this the correct spelling? Or is this feeding the HMP interface, where you documented it above as 'info migrate_parameters'? > +++ b/qapi-schema.json > @@ -345,6 +345,38 @@ > { 'command': 'query-migration-capabilities', 'returns': ['MigrationCap= abilityStatus'] } > =20 > ## > +# @migrate-set-parameters > +# > +# Enable/Disable the following migration capabilities (like xbzrle) > +# > +# Since: 1.2 Same comment as in 1/11 about 1.2 vs. 1.2.0. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA34854CA3DBDE6E66061C75B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQFs5pAAoJEKeha0olJ0NqZL0H/06oQOf+Mu9Uj8COPfiNE/Bq mqveJfX2IDP3ottyxo7yJarHEVETSJjfHHKOAROHNGfAarVAYZboCZ2LsRER86K4 AXzjUmL8cUXO+IIBMeio2AjxxLTYH9lfzHIn+uxnC7AJpM+76slM9vtyOkI4t9dz xxkIhfP/FLu0s8thEYwDSaqG92IGf93NYukRxI/WIBzqzk/soMuG+Yojp7U6d3Mj 3EVePQxwr0EJ0+Qo4JAhG+dcU9l0NUroWMMMnuM8mrwlfGTTPOkdt0CpsKIObI/c kpq+thMx3auTFh4wvfLu5+5IYLhZBc7bYGo0WTehcz+VJtrSGK6D/y/plOP+5+M= =t1mq -----END PGP SIGNATURE----- --------------enigA34854CA3DBDE6E66061C75B--