From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvvaK-0007dV-DC for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvvaG-00071P-8Z for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:24:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvvaG-00071H-0Z for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:24:52 -0400 Message-ID: <5016DF7A.1010305@redhat.com> Date: Mon, 30 Jul 2012 13:24:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343554983-4195-1-git-send-email-owasserm@redhat.com> <1343554983-4195-3-git-send-email-owasserm@redhat.com> <87zk6h3vy4.fsf@trasno.org> In-Reply-To: <87zk6h3vy4.fsf@trasno.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4149B3E8230E1E01879A8204" Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Orit Wasserman , avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4149B3E8230E1E01879A8204 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/30/2012 01:12 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration = by using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela >=20 > I just noticed .... shouldn't we use >=20 > migrate_set_parameter cache_size 256M > ??? >=20 > I think that even the old migration parameters could be added to this > one? >=20 > migrate_set_parameter downtime 30ms > migrate_set_parameter bandwidth 1G The existing patch was written under the assumption that parameters were only ever bool; but you are proposing allowing non-bool parameters. >=20 > This way everything would be more regular, and easier on libvirt, as ne= w > parameters would be trivial to ask for? That depends on the QMP interface you come up with for expressing non-bool parameters. This patch series has already been churning for several months now, which makes it feel a bit late to be changing the interface to support non-bool parameters, unless we really like the idea and can afford another delay in getting this series in. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4149B3E8230E1E01879A8204 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQFt97AAoJEKeha0olJ0Nq+kAIAIwSZM+sVGywy+Gu42UVmLxe gyIhOahVL9GtQOTTJysfJA93NCBNTP6z//e7mJ1p7rgtOmYPYDWJo5nsJoqxDnjx 6mSLRur1exMJUDG9e0Bj+aZF62nesroSBYIXeQRkqIWTmlsrWELJMC2BPLgLaPwa 9svFaY8nuCUazubY6SHQWSxOXEjpLVG4Gibx0hL0o5jhIMYa6Qrox+1KU782rCYr pSmNvemKDsdJHppLMja8tIa6PHes0LpD2FFQm2RWPTliMKa/d72uaZaA+FsCMeec Wzxssq0SspZBMQugOojR7TuNxhJ+io+RePBdwTrwZSnlQSsA0lh4NUlcrpC3HGs= =awnb -----END PGP SIGNATURE----- --------------enig4149B3E8230E1E01879A8204--