* [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
@ 2012-07-30 7:21 Andreas Jaeger
2012-07-30 21:30 ` Alexander Graf
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Jaeger @ 2012-07-30 7:21 UTC (permalink / raw)
To: qemu-devel; +Cc: riku.voipio
glibc 2.16 does not export the undocumented struct siginfo anymore.
qemu uses already in most cases siginfo_t, this patch fixes the last
three occurences.
Signed-off-by: Andreas Jaeger <ajsuse.de>
---
linux-user/signal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 97f30d9..a859a45 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -3255,7 +3255,7 @@ struct target_signal_frame {
};
struct rt_signal_frame {
- struct siginfo info;
+ siginfo_t info;
struct ucontext uc;
uint32_t tramp[2];
};
@@ -3474,9 +3474,9 @@ struct target_signal_frame {
};
struct rt_signal_frame {
- struct siginfo *pinfo;
+ siginfo_t *pinfo;
void *puc;
- struct siginfo info;
+ siginfo_t info;
struct ucontext uc;
uint8_t retcode[8]; /* Trampoline code. */
};
--
1.7.10.4
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
2012-07-30 7:21 [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo Andreas Jaeger
@ 2012-07-30 21:30 ` Alexander Graf
2012-07-30 21:33 ` Andreas Färber
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Graf @ 2012-07-30 21:30 UTC (permalink / raw)
To: Andreas Jaeger
Cc: Riku Voipio, qemu-devel qemu-devel, Andreas Färber,
Michael Roth
On 30.07.2012, at 09:21, Andreas Jaeger wrote:
>
> glibc 2.16 does not export the undocumented struct siginfo anymore.
> qemu uses already in most cases siginfo_t, this patch fixes the last
> three occurences.
>
> Signed-off-by: Andreas Jaeger <ajsuse.de>
That email address doesn't look valid :).
So I take it that the change is backwards compatible? Riku, Mike, Andreas, could we queue this for the respective stable branches when it gets it please?
Alex
> ---
> linux-user/signal.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 97f30d9..a859a45 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -3255,7 +3255,7 @@ struct target_signal_frame {
> };
>
> struct rt_signal_frame {
> - struct siginfo info;
> + siginfo_t info;
> struct ucontext uc;
> uint32_t tramp[2];
> };
> @@ -3474,9 +3474,9 @@ struct target_signal_frame {
> };
>
> struct rt_signal_frame {
> - struct siginfo *pinfo;
> + siginfo_t *pinfo;
> void *puc;
> - struct siginfo info;
> + siginfo_t info;
> struct ucontext uc;
> uint8_t retcode[8]; /* Trampoline code. */
> };
> --
> 1.7.10.4
>
>
> --
> Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
2012-07-30 21:30 ` Alexander Graf
@ 2012-07-30 21:33 ` Andreas Färber
2012-07-30 21:38 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2012-07-30 21:33 UTC (permalink / raw)
To: Alexander Graf
Cc: Andreas Jaeger, Riku Voipio, qemu-devel qemu-devel, Michael Roth
Am 30.07.2012 23:30, schrieb Alexander Graf:
>
> On 30.07.2012, at 09:21, Andreas Jaeger wrote:
>
>>
>> glibc 2.16 does not export the undocumented struct siginfo anymore.
>> qemu uses already in most cases siginfo_t, this patch fixes the last
>> three occurences.
>>
>> Signed-off-by: Andreas Jaeger <ajsuse.de>
>
> That email address doesn't look valid :).
>
> So I take it that the change is backwards compatible? Riku, Mike, Andreas, could we queue this for the respective stable branches when it gets it please?
Wasn't there already another patch doing the same thing a few weeks ago?
Andreas
>
>
> Alex
>
>> ---
>> linux-user/signal.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/linux-user/signal.c b/linux-user/signal.c
>> index 97f30d9..a859a45 100644
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -3255,7 +3255,7 @@ struct target_signal_frame {
>> };
>>
>> struct rt_signal_frame {
>> - struct siginfo info;
>> + siginfo_t info;
>> struct ucontext uc;
>> uint32_t tramp[2];
>> };
>> @@ -3474,9 +3474,9 @@ struct target_signal_frame {
>> };
>>
>> struct rt_signal_frame {
>> - struct siginfo *pinfo;
>> + siginfo_t *pinfo;
>> void *puc;
>> - struct siginfo info;
>> + siginfo_t info;
>> struct ucontext uc;
>> uint8_t retcode[8]; /* Trampoline code. */
>> };
>> --
>> 1.7.10.4
>>
>>
>> --
>> Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
>> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
>>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
2012-07-30 21:33 ` Andreas Färber
@ 2012-07-30 21:38 ` Peter Maydell
2012-07-30 21:41 ` Alexander Graf
2012-07-31 7:07 ` Andreas Jaeger
0 siblings, 2 replies; 6+ messages in thread
From: Peter Maydell @ 2012-07-30 21:38 UTC (permalink / raw)
To: Andreas Färber
Cc: Alexander Graf, qemu-devel qemu-devel, Riku Voipio, Michael Roth,
Richard W.M. Jones, Andreas Jaeger
On 30 July 2012 22:33, Andreas Färber <afaerber@suse.de> wrote:
> Am 30.07.2012 23:30, schrieb Alexander Graf:
>> On 30.07.2012, at 09:21, Andreas Jaeger wrote:
>>> glibc 2.16 does not export the undocumented struct siginfo anymore.
>>> qemu uses already in most cases siginfo_t, this patch fixes the last
>>> three occurences.
> Wasn't there already another patch doing the same thing a few weeks ago?
Yes: http://patchwork.ozlabs.org/patch/169170/
(It's also more complete than this patch, which misses one
occurrence in user-exec.c and one comment in linux-user/signal.c.)
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
2012-07-30 21:38 ` Peter Maydell
@ 2012-07-30 21:41 ` Alexander Graf
2012-07-31 7:07 ` Andreas Jaeger
1 sibling, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2012-07-30 21:41 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel qemu-devel, Riku Voipio, Michael Roth,
Richard W.M. Jones, Andreas Jaeger, Andreas Färber
On 30.07.2012, at 23:38, Peter Maydell wrote:
> On 30 July 2012 22:33, Andreas Färber <afaerber@suse.de> wrote:
>> Am 30.07.2012 23:30, schrieb Alexander Graf:
>>> On 30.07.2012, at 09:21, Andreas Jaeger wrote:
>>>> glibc 2.16 does not export the undocumented struct siginfo anymore.
>>>> qemu uses already in most cases siginfo_t, this patch fixes the last
>>>> three occurences.
>
>> Wasn't there already another patch doing the same thing a few weeks ago?
>
> Yes: http://patchwork.ozlabs.org/patch/169170/
>
> (It's also more complete than this patch, which misses one
> occurrence in user-exec.c and one comment in linux-user/signal.c.)
Ah, cool. Same thing I said before applies to this patch then. I'm fairly sure people want to be able to compile older QEMU on newer glibc.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
2012-07-30 21:38 ` Peter Maydell
2012-07-30 21:41 ` Alexander Graf
@ 2012-07-31 7:07 ` Andreas Jaeger
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Jaeger @ 2012-07-31 7:07 UTC (permalink / raw)
To: Peter Maydell
Cc: Alexander Graf, Richard W.M. Jones, Riku Voipio,
qemu-devel qemu-devel, Michael Roth, Andreas Färber
On Monday, July 30, 2012 22:38:32 Peter Maydell wrote:
> On 30 July 2012 22:33, Andreas Färber <afaerber@suse.de> wrote:
> > Am 30.07.2012 23:30, schrieb Alexander Graf:
> >> On 30.07.2012, at 09:21, Andreas Jaeger wrote:
> >>> glibc 2.16 does not export the undocumented struct siginfo
> >>> anymore.
> >>> qemu uses already in most cases siginfo_t, this patch fixes the
> >>> last
> >>> three occurences.
> >
> > Wasn't there already another patch doing the same thing a few weeks
> > ago?
> Yes: http://patchwork.ozlabs.org/patch/169170/
>
> (It's also more complete than this patch, which misses one
> occurrence in user-exec.c and one comment in linux-user/signal.c.)
Yes, let's apply that patch instead of mine,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-31 7:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 7:21 [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo Andreas Jaeger
2012-07-30 21:30 ` Alexander Graf
2012-07-30 21:33 ` Andreas Färber
2012-07-30 21:38 ` Peter Maydell
2012-07-30 21:41 ` Alexander Graf
2012-07-31 7:07 ` Andreas Jaeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).