From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sw8AH-0004WX-IW for qemu-devel@nongnu.org; Tue, 31 Jul 2012 04:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sw8AA-0000IV-3J for qemu-devel@nongnu.org; Tue, 31 Jul 2012 04:50:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sw8A9-0000IF-Ro for qemu-devel@nongnu.org; Tue, 31 Jul 2012 04:50:46 -0400 Message-ID: <50179C60.30105@redhat.com> Date: Tue, 31 Jul 2012 10:50:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-5-git-send-email-pbonzini@redhat.com> <50169E93.1020502@redhat.com> <5016A2C4.2020206@redhat.com> <50179BA6.9000507@redhat.com> In-Reply-To: <50179BA6.9000507@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 31/07/2012 10:47, Kevin Wolf ha scritto: >>> >> Why did you convert the initialisation to separate statement? If you >>> >> really want to do this, I think using g_new0 would be safer now, but I >>> >> actually like compound literals better. >> > >> > Later on I will have some more initialization beyond the list of fields, >> > so I preferred an explicit list. I can change it back if you prefer. > What I'm really interested in is having zero-initialisation for any not > explicitly initialised fields, just to be on the safe side. You can do > that with g_new0() or with compound literals, that's a matter of taste. Yes, and in fact I even have a change to g_new0 later in the series. I'll squash that change in this patch. Paolo