From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Zhi Yong Wu <wuzhy@cn.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work
Date: Tue, 31 Jul 2012 13:41:07 +0200 [thread overview]
Message-ID: <5017C453.8080800@redhat.com> (raw)
In-Reply-To: 1342790753-12727-1-git-send-email-stefanha@linux.vnet.ibm.com
(in reply to
<http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html> --
In-Reply-To set, but that may not be enough for the web archive)
Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
of calling closesocket(s->fd), like in eoc handling) in
net_socket_cleanup().
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next reply other threads:[~2012-07-31 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 11:41 Laszlo Ersek [this message]
2012-07-31 13:04 ` [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work Stefan Hajnoczi
2012-07-31 14:20 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2012-07-20 13:25 Stefan Hajnoczi
2012-07-31 13:31 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017C453.8080800@redhat.com \
--to=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).