From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SwAnz-0000kX-PJ
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 07:40:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SwAny-00005Y-Ep
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 07:40:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56531)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SwAny-0008V0-6W
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 07:40:02 -0400
Message-ID: <5017C453.8080800@redhat.com>
Date: Tue, 31 Jul 2012 13:41:07 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
In-Reply-To: 1342790753-12727-1-git-send-email-stefanha@linux.vnet.ibm.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Zhi Yong Wu <wuzhy@cn.ibm.com>

(in reply to
<http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html> --
In-Reply-To set, but that may not be enough for the web archive)

Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
of calling closesocket(s->fd), like in eoc handling) in
net_socket_cleanup().

Reviewed-by: Laszlo Ersek <lersek@redhat.com>