From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SwDJQ-0003In-Ld
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:20:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SwDJJ-0006Xo-Sh
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:20:40 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:58106)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SwDJI-0006Vq-Jk
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:20:33 -0400
Received: by yenl1 with SMTP id l1so5930770yen.4
	for <qemu-devel@nongnu.org>; Tue, 31 Jul 2012 07:20:17 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5017E999.8070404@redhat.com>
Date: Tue, 31 Jul 2012 16:20:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5017C453.8080800@redhat.com>
	<CAJSP0QUOxPYqedQ9aepDPSjU0VtBm-q636q9OG0dKzRTojzojQ@mail.gmail.com>
In-Reply-To: <CAJSP0QUOxPYqedQ9aepDPSjU0VtBm-q636q9OG0dKzRTojzojQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Zhi Yong Wu <wuzhy@cn.ibm.com>

Il 31/07/2012 15:04, Stefan Hajnoczi ha scritto:
>> > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
>> > of calling closesocket(s->fd), like in eoc handling) in
>> > net_socket_cleanup().
> The reason I didn't change close(2) to closesocket() is because
> -netdev socket,fd= can pass arbitrary file descriptors.  I suspect
> only real socket objects will work but we basically don't know what
> the passed file descriptor is.  This is the reason why I didn't feel
> 100% happy converting it to closesocket().
> 

-netdev socket,fd= is probably not usable from Windows, so no problem
using close().

Paolo