From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGXb-0005bN-Q2 for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwGXX-0007OL-HV for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:47:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGXX-0007OD-8E for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:47:27 -0400 Message-ID: <50181A28.7020705@redhat.com> Date: Tue, 31 Jul 2012 11:47:20 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120730213409.21536.7589.sendpatchset@skannery.in.ibm.com> <20120730213625.21536.69391.sendpatchset@skannery.in.ibm.com> In-Reply-To: <20120730213625.21536.69391.sendpatchset@skannery.in.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5FD6316849B6CEE16C53D7EA" Subject: Re: [Qemu-devel] [v2 Patch 9/9]block: Enhance "info block" to display host cache setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Supriya Kannery Cc: Kevin Wolf , Shrinidhi Joshi , Stefan Hajnoczi , Jeff Cody , qemu-devel@nongnu.org, Luiz Capitulino , Christoph Hellwig This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5FD6316849B6CEE16C53D7EA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/30/2012 03:36 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. >=20 > Example: > (qemu) info block > ide0-hd0: removable=3D0 file=3D../rhel6-32.raw ro=3D0 drv=3Draw encrypt= ed=3D0 >=20 > Enhanced to display "hostcache" setting: > (qemu) info block > ide0-hd0: removable=3D0 hostcache=3D1 file=3D../rhel6-32.raw ro=3D0 drv= =3Draw encrypted=3D0 >=20 > Signed-off-by: Supriya Kannery >=20 > --- No diffstat? It's not a hard requirement, but it can make patch review easier if 'git send-email' is set up to include diffstats. > Index: qemu/qapi-schema.json > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- qemu.orig/qapi-schema.json > +++ qemu/qapi-schema.json > @@ -453,6 +453,8 @@ > # @locked: True if the guest has locked this device from having its me= dia > # removed > # > +# @hostcache: True if host pagecache is enabled. > +# Missing a counterpart change to qmp-commands.hx to document it in use. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5FD6316849B6CEE16C53D7EA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGBopAAoJEKeha0olJ0NqqDAH/jz8BeTFR+xlNXX9IuteuWEP zdQ804g/+omcY067sVoc4vHgBOvA0VEEHIY/LRE9PBVU2Oz95Sr8vPRYc4yAuAli d1ka6K0r3GmWe/KicZ+W0OtXqN46u4G3PJ3IcCuVGzaerdYeV+1gRlDo18ZKkMzM xqfRj5KS7qaKuvk2doSuo3jiqsOu5kz8HQP9bOB4C8TWTNZm9NuQ51/cRXy0q2pf sYvhRExdeg48I0AOLG3hC/M7TmL0FmuuP/H1zhFcEdPM7pI45my2UBOg0Z26wQWX +yuBRiO482SI0cY7nxZXT+4Nv1wcOE9WZv16gmVqmNT0EhnXcRYebC+tQOgTYLM= =OyAm -----END PGP SIGNATURE----- --------------enig5FD6316849B6CEE16C53D7EA--