From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwHLS-0008K9-C9 for qemu-devel@nongnu.org; Tue, 31 Jul 2012 14:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwHLQ-0001of-Si for qemu-devel@nongnu.org; Tue, 31 Jul 2012 14:39:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwHLQ-0001oN-KT for qemu-devel@nongnu.org; Tue, 31 Jul 2012 14:39:00 -0400 Message-ID: <5018263F.4070705@redhat.com> Date: Tue, 31 Jul 2012 12:38:55 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4671F1207C1F14C78E19D188" Subject: Re: [Qemu-devel] [RFC PATCH 4/4] QAPI: add command for live block commit, 'block-commit' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4671F1207C1F14C78E19D188 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/30/2012 11:16 PM, Jeff Cody wrote: > The command for live block commit is added, which has the following > arguments: >=20 > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original image) > top: the top image of the commit - all data from inside top down > to base will be committed into base. optional (if not specified= , > it is the active image) - see note below > speed: maximum speed, in bytes/sec > on_error: action to take on error (optional - default is report) >=20 > note: eventually this will support merging down the active layer, > but that code is not yet complete. If the active layer is passed= > in currently as top, or top is left to the default, then the erro= r > QERR_TOP_NOT_FOUND will be returned. >=20 > The is down as a block job, so upon completion a BLOCK_JOB_COMPLETED wi= ll > be emitted. s/The is down/This is done/ ? Also, how does block-job-cancel interact with the job started by this command? Is it something we can cancel and restart at will, like block-stream? > +++ b/qapi-schema.json > @@ -1365,6 +1365,39 @@ > 'returns': 'str' }=20 > =20 > ## > +# @block-commit > +# > +# Live commit of data from child image nodes into parent nodes - i.e.,= > +# writes data between 'top' and 'base' into 'base'. > +# > +# @device: the name of the device > +# > +# @base: #optional The parent image of the device to write data into= =2E > +# If not specified, this is the original parent ima= ge. > +# > +# @top: #optional The child image, above which data will not be com= mited s/commited/committed/ > +# @on_error: #optional the action to take on an error (default report)= > +# > +# Returns: Nothing on success > +# If commit or stream is already active on this device, Devic= eInUse > +# If @device does not exist, DeviceNotFound > +# If image commit is not supported by this device, NotSupport= ed > +# If @base does not exist, BaseNotFound > +# If @top does not exist, TopNotFound > +# If @speed is invalid, InvalidParameter > +# > +# Since: 1.2 > +# > +## > +{ 'command': 'block-commit', > + 'data': { 'device': 'str', '*base': 'str', '*top': 'str', > + '*speed': 'int', '*on_error': 'BlockdevOnError' } } s/on_error/on-error/ (hmm, I guess you were copying from Paolo's series, so he probably has the same change to make) --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4671F1207C1F14C78E19D188 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGCZAAAoJEKeha0olJ0NqJPAH/2YUmIWw35Oxo1zp3eDslmkL mfCjus00kHgvzDW/ZczqqWmxumdYR+YJVE8azZ7shxXcDT6SN0J8eDfL9hcGgFwF qlFT67Zn1z7iAK5Err8QeWsrOdGrPf8U60Q9yMtqIar36/wWahIBDt4n+Vv8mOXE 4jCdLjJCm6qggoyNIRvcjaOR6SGEmTT+uhzxjyGUeW4pCYks/rqTzFNbKC04TryT kLWW5+LJyyf3tVFsZs4WB9sST6JuWE0V37o8ybKo8NdmgsHJMT0fVxCoVZTlrdmG f36E2jlw65uFgh7+YRuASYWmKS5S7OULNiH1IA/2+9syE8tlxGo86wnWrNT1exc= =XFNU -----END PGP SIGNATURE----- --------------enig4671F1207C1F14C78E19D188--