From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwJ0r-0003Xh-PL for qemu-devel@nongnu.org; Tue, 31 Jul 2012 16:25:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwJ0q-0005Qj-HT for qemu-devel@nongnu.org; Tue, 31 Jul 2012 16:25:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwJ0q-0005Qb-8b for qemu-devel@nongnu.org; Tue, 31 Jul 2012 16:25:52 -0400 Message-ID: <50183231.3060201@redhat.com> Date: Tue, 31 Jul 2012 13:29:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343760889-21806-1-git-send-email-owasserm@redhat.com> <1343760889-21806-3-git-send-email-owasserm@redhat.com> In-Reply-To: <1343760889-21806-3-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig021D70BDDD40EB2DEF97D540" Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig021D70BDDD40EB2DEF97D540 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2012 12:54 PM, Orit Wasserman wrote: Subject line is stale. > The management can enable/disable a capability for the next migration b= y using > migrate_set_capabilities QMP command. The QMP command is spelled migrate-set-capabilities. > The management can query the current migration capabilities using > query-migrate-capabilities QMP command. > The user can use migrate_set_capability and 'info migrate_capabilities'= HMP > commands. >=20 > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qmp-commands.hx > @@ -2081,7 +2081,6 @@ The main json-object contains the following: > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > - > Examples: Spurious whitespace change. > =20 > 1. Before the first migration > @@ -2092,7 +2091,15 @@ Examples: > 2. Migration is done and has succeeded > =20 > -> { "execute": "query-migrate" } > -<- { "return": { "status": "completed" } } > +<- { "return": { > + "status": "completed", > + "ram":{ > + "transferred":123, > + "remaining":123, > + "total":246 > + } > + } > + } This hunk is unrelated to the new commands, and not mentioned in the commit message. It's a good change (making the examples match the code), but belongs better in a separate cleanup commit that scrubs existing docs before adding new docs. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig021D70BDDD40EB2DEF97D540 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGDIyAAoJEKeha0olJ0NqSVkH/3W+sl6fivUD4RVxEGlByVNI oQYD0PNp0Jbtc9GS7vJr/C28aQ0uBcsHripDc8m/DvyYqS97Pot7T1GuEZdIk9q6 mKaH8z4CkQ2/eGBppyAcn0PrIb40/1T0h8RenORfKDt5o4hGejXshkVU5wIkALDl 53GM4y8pGT0SDcKEeiv0y9GEZqbpEAc8PriL9LXBVoTcSu3KZlE/FpPKgQMrE5et lZOLO9P4ZqFb+Z1qhljinz0IC3kTh05nG/pwWHZjx4y1OXVaVfjiL+T74P29hryn qbYnc1nb7+Ke52v4pWvFGdzjKHPvBYXW9HhRv5kvkjLhCQ7CAZCL/Zjbi2ULwHw= =kKjX -----END PGP SIGNATURE----- --------------enig021D70BDDD40EB2DEF97D540--