From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwUZD-00044W-BF for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwUZ7-0007MN-O3 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:46:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwUZ7-0007MD-GD for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:46:01 -0400 Message-ID: <5018ECC0.2090802@redhat.com> Date: Wed, 01 Aug 2012 10:45:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343807602-2229-1-git-send-email-mc@linux.vnet.ibm.com> <5018E6CC.3060308@redhat.com> <5018EC3C.5070005@linux.vnet.ibm.com> In-Reply-To: <5018EC3C.5070005@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cong Meng Cc: zwanp@cn.ibm.com, linuxram@us.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org Il 01/08/2012 10:43, Cong Meng ha scritto: >> >> Please make this conditional on the type _not_ being TYPE_ROM. > > May I ask why cdrom device should be an exception? Because CD-ROM devices do not support ATA PASSTHROUGH (the SAT standard only describes direct access devices---type=0x00). The 0xa1 command is "BLANK" for CD-ROMs. Paolo