From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwV1P-0002Gl-Ad for qemu-devel@nongnu.org; Wed, 01 Aug 2012 05:15:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwV1J-0007kN-IP for qemu-devel@nongnu.org; Wed, 01 Aug 2012 05:15:15 -0400 Message-ID: <5018F39C.6090904@suse.de> Date: Wed, 01 Aug 2012 11:15:08 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1343714097-545-1-git-send-email-sw@weilnetz.de> <5017EE1D.8060908@suse.de> <5017EEFD.5070503@redhat.com> <5017EFC6.1050705@suse.de> <5017F0A2.5030400@redhat.com> <5017F1E3.90806@suse.de> <87y5m06jx1.fsf@codemonkey.ws> <5017FD81.3040707@redhat.com> <50185960.9050700@suse.de> <5018DCEB.9060208@redhat.com> <5018E0BE.3000706@suse.de> <5018E25E.4010801@redhat.com> In-Reply-To: <5018E25E.4010801@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, Stefan Weil , Alexander Graf , qemu-devel@nongnu.org, Anthony Liguori , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 08/01/2012 10:01 AM, Paolo Bonzini wrote: > Il 01/08/2012 09:54, Hannes Reinecke ha scritto: >> On 08/01/2012 09:38 AM, Paolo Bonzini wrote: >>> Il 01/08/2012 00:17, Hannes Reinecke ha scritto: >>>> Ad 2: no, the SAS address for the devices is _not_ the WWN. >>>> The WWN is the ID of the LUN, whereas the SAS address is the ID of t= he >>>> Target. So to be correct we would need to generate unique SAS addres= sed >>>> per target which needs to be different from the WWN. >>> >>> Oh, that's even easier then, just delete all the get_wwn stuff and us= e >>> HBA address + 1 + sdev->id. >>> >> Which HBA address? >=20 > The HBA SAS address. :) >=20 Ah. I've now send a new patch fixing things up. Hopefully it gains Anthonys approval. Anthony, I'm dead sorry but didn't manage to type your e-mail address correctly. Hope it doesn't fall through the cracks because of this .. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg GF: J. Hawn, J. Guild, F. Imend=C3=B6rffer, HRB 16746 (AG N=C3=BCrnberg)