From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SwWnz-0005N6-Iu
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 07:09:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SwWnt-0008ES-RT
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 07:09:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SwWnt-0008EH-If
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 07:09:25 -0400
Message-ID: <50190E60.9060101@redhat.com>
Date: Wed, 01 Aug 2012 13:09:20 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com>
	<1343127865-16608-18-git-send-email-pbonzini@redhat.com>
	<5019084A.3000902@redhat.com>
In-Reply-To: <5019084A.3000902@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/47] qemu-iotests: add tests for
	streaming error handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 01/08/2012 12:43, Kevin Wolf ha scritto:
>> > +
>> > +    def test_report(self):
>> > +        self.assert_no_active_streams()
>> > +
>> > +        result = self.vm.qmp('block-stream', device='drive0')
>> > +        self.assert_qmp(result, 'return', {})
>> > +
>> > +        completed = False
>> > +        error = False
>> > +        while not completed:
>> > +            for event in self.vm.get_qmp_events(wait=True):
>> > +                if event['event'] == 'BLOCK_JOB_ERROR':
>> > +                    self.assert_qmp(event, 'data/device', 'drive0')
>> > +                    self.assert_qmp(event, 'data/operation', 'read')
> data/action should be asserted as well (same in the other tests).
> 
> What about adding an enospc test as well, once with EIO and once with
> ENOSPC?

Ok.

Paolo