From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SwYTm-0002Vg-OZ
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 08:56:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SwYTi-0008He-8E
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 08:56:46 -0400
Message-ID: <50192786.5080904@redhat.com>
Date: Wed, 01 Aug 2012 15:56:38 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com>
In-Reply-To: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in
	register_subpage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tyler Hall <tylerwhall@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 07/26/2012 01:45 AM, Tyler Hall wrote:
> subpage_register() expects "end" to be the last byte in the mapping.
> Registering a non-page-aligned memory region that extends up to or
> beyond a page boundary causes subpage_register() to silently fail
> through the (end >= PAGE_SIZE) check.
> 
> This bug does not cause noticeable problems for mappings that do not
> extend to a page boundary, though they do register an extra byte.

Reviewed-by: Avi Kivity <avi@redhat.com>


-- 
error compiling committee.c: too many arguments to function