From: Avi Kivity <avi@redhat.com>
To: Tyler Hall <tylerwhall@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings
Date: Wed, 01 Aug 2012 16:02:04 +0300 [thread overview]
Message-ID: <501928CC.50201@redhat.com> (raw)
In-Reply-To: <1343256304-32029-2-git-send-email-tylerwhall@gmail.com>
On 07/26/2012 01:45 AM, Tyler Hall wrote:
> Registering a multi-page memory region that is non-page-aligned results
> in a subpage from the start to the page boundary, some number of full
> pages, and possibly another subpage from the last page boundary to the
> end. The full pages will have a value for offset_within_region that is
> not a multiple of TARGET_PAGE_SIZE. Accesses through softmmu are unable
> to handle this and will segfault.
>
> Handling full pages through subpages is not optimal, but only
> non-page-aligned mappings take the penalty.
Reviewed-by: Avi Kivity <avi@redhat.com>
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-01 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 22:45 [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Tyler Hall
2012-07-25 22:45 ` [Qemu-devel] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings Tyler Hall
2012-08-01 13:02 ` Avi Kivity [this message]
2012-08-01 10:42 ` [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Stefan Hajnoczi
2012-08-01 12:52 ` Peter Maydell
2012-08-01 12:56 ` [Qemu-devel] " Avi Kivity
2012-08-01 13:01 ` Stefan Hajnoczi
2012-08-01 13:03 ` Avi Kivity
2012-08-03 9:55 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501928CC.50201@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).