From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwYYz-0000Fc-QX for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:02:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwYYy-0001q8-Mb for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:02:09 -0400 Message-ID: <501928CC.50201@redhat.com> Date: Wed, 01 Aug 2012 16:02:04 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com> <1343256304-32029-2-git-send-email-tylerwhall@gmail.com> In-Reply-To: <1343256304-32029-2-git-send-email-tylerwhall@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tyler Hall Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 07/26/2012 01:45 AM, Tyler Hall wrote: > Registering a multi-page memory region that is non-page-aligned results > in a subpage from the start to the page boundary, some number of full > pages, and possibly another subpage from the last page boundary to the > end. The full pages will have a value for offset_within_region that is > not a multiple of TARGET_PAGE_SIZE. Accesses through softmmu are unable > to handle this and will segfault. > > Handling full pages through subpages is not optimal, but only > non-page-aligned mappings take the penalty. Reviewed-by: Avi Kivity -- error compiling committee.c: too many arguments to function