From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwYaR-00014s-Ve for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwYaM-0002Hg-5U for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:03:39 -0400 Message-ID: <50192915.8080203@redhat.com> Date: Wed, 01 Aug 2012 16:03:17 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com> <50192786.5080904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Tyler Hall On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote: > On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity wrote: >> On 07/26/2012 01:45 AM, Tyler Hall wrote: >>> subpage_register() expects "end" to be the last byte in the mapping. >>> Registering a non-page-aligned memory region that extends up to or >>> beyond a page boundary causes subpage_register() to silently fail >>> through the (end >= PAGE_SIZE) check. >>> >>> This bug does not cause noticeable problems for mappings that do not >>> extend to a page boundary, though they do register an extra byte. >> >> Reviewed-by: Avi Kivity > > Thanks Avi. Does this include Patch 2/2 too? I reviewed that as well with similar results. -- error compiling committee.c: too many arguments to function