From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwYwX-0001ce-8a for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:26:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwYwV-0001Lq-D8 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:26:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwYwV-0001Ll-3b for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:26:27 -0400 Message-ID: <50192E62.5020200@redhat.com> Date: Wed, 01 Aug 2012 07:25:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343812186-11594-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE2F41CAB1BF87EC71BBA5E6F" Subject: Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: pbonzini@redhat.com, aliguori@us.ibm.com, Wenchao Xia , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE2F41CAB1BF87EC71BBA5E6F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: > On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia wrote: >> This patch encapsulate qemu general block layer to provide block >> services. API are declared in libqblock.h. libqblock-test.c >> simulate library consumer's behaviors. Make libqblock-test could >> build the code. >> For easy this patch does not form a dynamic libarary yet. >> >> +++ b/libqblock-test.c >> @@ -0,0 +1,56 @@ >> +#include "libqblock.h" >=20 > Please include GPLv2+ license headers in new source files you create. > See existing code like include/qemu/object.h for the license header > text. Actually, LGPLv2+ (or compatible, like BSD), if you plan on making this a reusable library. GPLv2+ is too strict for libvirt to use directly. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE2F41CAB1BF87EC71BBA5E6F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGS5jAAoJEKeha0olJ0NqLL0H/0lMk8SC2/b17qYgSIysZkir DmnzFwPQ8KrwUDKNafH1iIKfRuNWALNrt/JlGe2HgSrJmSIcPJ1REiwQW7r07/f2 1pdPdaV2JykGpMu4c2bwrRWZLbe0zwgGUUYGrM4GIQIJm6ZToNDhbC1RDNVZwGrZ rYrmI2Wk9VdrpUBWCGEhWYYVUJl7FHOBQqRU8reFJCsSxIVMamVgsiJiBFnX+DTX OU1W8QZUXCPlmc0jJqncAJcHLsldbnzjhkl8kYsA++U9vW3Kcl+GhLM5RHWgwOwU sfIfN3j/Z5K7Z7+yTU8cI4ql8kg/Qm7U5IjXEUrlCCLcFTXJgqtkfU2+1Wnckyo= =Y+cg -----END PGP SIGNATURE----- --------------enigE2F41CAB1BF87EC71BBA5E6F--