From: "Andreas Färber" <afaerber@suse.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
xen-devel@lists.xensource.com, qemu-devel@nongnu.org,
fantonifabio@tiscali.it, Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] fix Xen compilation
Date: Wed, 01 Aug 2012 15:33:50 +0200 [thread overview]
Message-ID: <5019303E.30508@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1208011114490.4645@kaball.uk.xensource.com>
Am 01.08.2012 12:19, schrieb Stefano Stabellini:
> xen_pt_unregister_device is used as PCIUnregisterFunc, so it should
> match the type.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tested-by: Andreas Färber <afaerber@suse.de>
/-F
>
> diff --git a/hw/xen_pt.c b/hw/xen_pt.c
> index fdf68aa..307119a 100644
> --- a/hw/xen_pt.c
> +++ b/hw/xen_pt.c
> @@ -764,7 +764,7 @@ out:
> return 0;
> }
>
> -static int xen_pt_unregister_device(PCIDevice *d)
> +static void xen_pt_unregister_device(PCIDevice *d)
> {
> XenPCIPassthroughState *s = DO_UPCAST(XenPCIPassthroughState, dev, d);
> uint8_t machine_irq = s->machine_irq;
> @@ -814,8 +814,6 @@ static int xen_pt_unregister_device(PCIDevice *d)
> memory_listener_unregister(&s->memory_listener);
>
> xen_host_pci_device_put(&s->real_device);
> -
> - return 0;
> }
>
> static Property xen_pci_passthrough_properties[] = {
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-01 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 10:19 [Qemu-devel] [PATCH] fix Xen compilation Stefano Stabellini
2012-08-01 13:33 ` Andreas Färber [this message]
2012-08-01 13:40 ` Stefano Stabellini
2012-08-01 15:42 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5019303E.30508@suse.de \
--to=afaerber@suse.de \
--cc=Ian.Campbell@citrix.com \
--cc=anthony@codemonkey.ws \
--cc=fantonifabio@tiscali.it \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).