From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZMp-0007BN-Ou for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwZMl-0001Qa-GD for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:53:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZMl-0001QU-5y for qemu-devel@nongnu.org; Wed, 01 Aug 2012 09:53:35 -0400 Message-ID: <501934D2.1040604@redhat.com> Date: Wed, 01 Aug 2012 07:53:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343753510-24661-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1343753510-24661-2-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1343753510-24661-2-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1CD1B45AED93B37A09E1A505" Subject: Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1CD1B45AED93B37A09E1A505 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2012 10:51 AM, Dong Xu Wang wrote: > In add-cow file format, we will use path_has_protocol and we will read > a NUL-terminated string from image , qed_read_string has done the samet= hing, s/image ,/image,/ s/samething/same thing/ > so make the two functions public, then we will reuse them directly. >=20 > While creating images files, if no size is specified, will use size of = backing > file. If no backing file is specified, we will use the size of image fi= le. >=20 > Signed-off-by: Dong Xu Wang > --- > block.c | 37 +++++++++++++++++++++++++++++++++---- > block.h | 3 +++ > block/qed.c | 29 +---------------------------- > 3 files changed, 37 insertions(+), 32 deletions(-) >=20 > + /* The size for the image must always be specified, with one excep= tion: > + If we are using a backing file, we can obtain the size from there= , > + but if not, and we are using an image file, we will obtain the si= ze from it.*/ grammar: The size for the image must be known, either by direct specification, or by reading it from a backing file or image file. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1CD1B45AED93B37A09E1A505 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGTTTAAoJEKeha0olJ0NqKxoH/jLrxm+PTc+7mpb3fd19dZ1p 1nrJq65/oAH5yduK+Su1oVdDfaeYVRu79yrKsOCoJNf0nAHLwvJrtbtmlL8BE2DH qr8n38c430U5gNRA920lAnBG62DNG5Wb/7LJw7EH+Ms2/UEnyTqquN+nQiGw2xCg 6Sbv7MKMBZKKmF9ZyRG5GK9Gd/NFgD1SmNwk1dG6RkzMl+4SpABDPXGEscSkd7e3 QH8HkEpJj0+hhN15wYmwl7K9nsODGlrtH+GeIm/7uD+TCZ3eJra+Z5xLqrplZTNZ 8b+JV9PeKg94VmAyEZhRilW548Mv1NwjmGgRQh27CaVIgwkkfQEfjkz5geNPApA= =cGVQ -----END PGP SIGNATURE----- --------------enig1CD1B45AED93B37A09E1A505--