From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZdx-0000bD-I6 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwZdu-0007Qw-1v for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:11:21 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:47962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZdt-0007Qm-U2 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:11:17 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 10:11:16 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 7CCFE6E8107 for ; Wed, 1 Aug 2012 10:09:52 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q71E5s0x366926 for ; Wed, 1 Aug 2012 10:09:49 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q71E1Cpu032354 for ; Wed, 1 Aug 2012 08:01:12 -0600 Message-ID: <5019365C.2060906@us.ibm.com> Date: Wed, 01 Aug 2012 08:59:56 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1341611595-9847-1-git-send-email-hpoussin@reactos.org> <1341611595-9847-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1341611595-9847-2-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org On 07/06/2012 04:53 PM, Hervé Poussineau wrote: > Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: > -chardev stdio,id=debugcon,mux=on > -device isa-debugcon,iobase=0x402,chardev=debugcon > -device isa-debugcon,iobase=0x403,chardev=debugcon > -device isa-debugcon,iobase=0x500,chardev=debugcon > -device isa-debugcon,iobase=0x503,chardev=debugcon > > QEMU exit (which can be guest trigged) can be replaced by: > -device isa-debugexit,iobase=0x501 > -device isa-debugexit,iobase=0x501,access-size=2 > -device isa-debugexit,iobase=0x502,access-size=2 > > Signed-off-by: Hervé Poussineau > --- > > Anthony, this patch is a follow-up of a patch I sent in March 2012: > http://lists.gnu.org/archive/html/qemu-devel/2012-03/msg00031.html > > Will you accept this approach, where your regression suite will require > a new parameter "-device isa-debugexit,iobase=0x501" ? > > hw/pc.c | 35 ----------------------------------- > 1 file changed, 35 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index c7e9ab3..a328fb2 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -49,9 +49,6 @@ > #include "exec-memory.h" > #include "arch_init.h" > > -/* output Bochs bios info messages */ > -//#define DEBUG_BIOS > - > /* debug PC/ISA interrupts */ > //#define DEBUG_IRQ > > @@ -540,17 +537,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > static int shutdown_index = 0; > > switch(addr) { > - /* Bochs BIOS messages */ > - case 0x400: > - case 0x401: > - /* used to be panic, now unused */ > - break; > - case 0x402: > - case 0x403: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > case 0x8900: > /* same as Bochs power off */ > if (val == shutdown_str[shutdown_index]) { > @@ -563,17 +549,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > shutdown_index = 0; > } > break; > - > - /* LGPL'ed VGA BIOS messages */ > - case 0x501: > - case 0x502: > - exit((val<< 1) | 1); > - case 0x500: > - case 0x503: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > } > } > > @@ -602,18 +577,8 @@ static void *bochs_bios_init(void) > uint64_t *numa_fw_cfg; > int i, j; > > - register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); > register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); > > - register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x501, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x502, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x500, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x503, 1, 1, bochs_bios_write, NULL); > - > fw_cfg = fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 1, 0, 0); > > fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); Removing this from the default PC breaks compatibility. I don't mind having a way to disable it but it needs to be there by default. Among other things, my test suite depends on these ports. Regards, Anthony Liguori