From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZYC-0007mH-24 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:05:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwZY7-0005LM-Pe for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:05:23 -0400 Message-ID: <5019379B.5080206@redhat.com> Date: Wed, 01 Aug 2012 17:05:15 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec.c: Remove out of date comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org On 08/01/2012 04:35 PM, Peter Maydell wrote: > Remove an out of date comment: this comment used to be attached to > cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally > inserted a couple of other functions between the comment and its function. > It is in any case obsolete since (a) the function arguments it refers > to have been replaced with a single MemoryRegionSection* argument and > (b) the inability to handle regions whose offset_within_address_space > and offset_within_region aren't equally aligned was fixed as part of > the rewrite of this code. (c) it doesn't use the conventional block comment style. > > Signed-off-by: Peter Maydell > --- > Pretty sure my analysis is right and this comment is out of date -- > Avi, could you confirm that please? Yes, you are correct. -- error compiling committee.c: too many arguments to function