From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swak7-0001kc-Ow for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:21:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swak2-0004Iq-Vu for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:21:47 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:38705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swak2-0004Hg-DY for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:21:42 -0400 Message-ID: <50194975.1060306@reactos.org> Date: Wed, 01 Aug 2012 17:21:25 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1341611595-9847-1-git-send-email-hpoussin@reactos.org> <1341611595-9847-2-git-send-email-hpoussin@reactos.org> <5019365C.2060906@us.ibm.com> In-Reply-To: <5019365C.2060906@us.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Anthony Liguori a =C3=A9crit : > On 07/06/2012 04:53 PM, Herv=C3=A9 Poussineau wrote: >> Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: >> -chardev stdio,id=3Ddebugcon,mux=3Don >> -device isa-debugcon,iobase=3D0x402,chardev=3Ddebugcon >> -device isa-debugcon,iobase=3D0x403,chardev=3Ddebugcon >> -device isa-debugcon,iobase=3D0x500,chardev=3Ddebugcon >> -device isa-debugcon,iobase=3D0x503,chardev=3Ddebugcon >> >> QEMU exit (which can be guest triggered) can be replaced by: >> -device isa-debugexit,iobase=3D0x501 >> -device isa-debugexit,iobase=3D0x501,access-size=3D2 >> -device isa-debugexit,iobase=3D0x502,access-size=3D2 >> >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> >> Anthony, this patch is a follow-up of a patch I sent in March 2012: >> http://lists.gnu.org/archive/html/qemu-devel/2012-03/msg00031.html >> >> Will you accept this approach, where your regression suite will requir= e >> a new parameter "-device isa-debugexit,iobase=3D0x501" ? >> [...] >> >> @@ -602,18 +577,8 @@ static void *bochs_bios_init(void) >> uint64_t *numa_fw_cfg; >> int i, j; >> >> - register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); >> - register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); >> - register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); >> - register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); >> register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); >> >> - register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); >> - register_ioport_write(0x501, 1, 2, bochs_bios_write, NULL); >> - register_ioport_write(0x502, 1, 2, bochs_bios_write, NULL); >> - register_ioport_write(0x500, 1, 1, bochs_bios_write, NULL); >> - register_ioport_write(0x503, 1, 1, bochs_bios_write, NULL); >> - >> fw_cfg =3D fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 1, 0, = 0); >> >> fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); >=20 > Removing this from the default PC breaks compatibility. I don't mind=20 > having a way to disable it but it needs to be there by default. >=20 > Among other things, my test suite depends on these ports. >=20 OK for keeping them on compat PC machines. However, for current ones (1.2 or later), I don't want to have them by=20 default as it is an QEMU exit which is guest triggerable. Will you accept this approach, where your regression suite will require a new parameter "-device isa-debugexit,iobase=3D0x501" ? Regards, Herv=C3=A9