From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbBk-00041J-Pp for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:50:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwbBh-0004fo-N7 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:50:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33844 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbBh-0004fU-Gq for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:50:17 -0400 Message-ID: <50195034.9050201@suse.de> Date: Wed, 01 Aug 2012 17:50:12 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> <87zk6elisw.fsf@codemonkey.ws> In-Reply-To: <87zk6elisw.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: peter.maydell@linaro.org, ehabkost@redhat.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, Igor Mammedov Am 01.08.2012 17:43, schrieb Anthony Liguori: > Igor Mammedov writes: >=20 >> v2: >> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cp= u(), >> to keep cpu_init implementation in -softmmu and -user targets the sa= me >> in single place and maintanable. >> >> v3: >> reuse cpu_is_bsp() rather than open code check if apicbase has BSP b= it set >> >> tree for testing: >> https://github.com/imammedo/qemu/tree/x86_reset_v3 >> >> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets >> >> Igor Mammedov (2): >> target-i386: move cpu halted decision into x86_cpu_reset >> target-i386: move cpu_reset and reset callback to cpu.c >=20 > Applied all. Thanks. So do you intend to refactor all machines accordingly or leave it inconsistent now? Andreas >=20 > Regards, >=20 > Anthony Liguori >=20 >> >> hw/apic.h | 5 ++++- >> hw/apic_common.c | 16 +++++++++++++--- >> hw/pc.c | 18 +----------------- >> target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++ >> target-i386/helper.c | 1 - >> target-i386/kvm.c | 4 +++- >> 6 files changed, 51 insertions(+), 23 deletions(-) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg