From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbCt-0005Tc-8F for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwbCs-000584-6l for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:51:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbCr-000580-UT for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:51:30 -0400 Message-ID: <5019507E.2050400@redhat.com> Date: Wed, 01 Aug 2012 09:51:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343814538-27591-1-git-send-email-lilei@linux.vnet.ibm.com> <1343814538-27591-5-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1343814538-27591-5-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE20A354BD23D8B82BB9E39DA" Subject: Re: [Qemu-devel] [RFC PATCH 4/4] qmp: Introduce memchar_read QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE20A354BD23D8B82BB9E39DA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/01/2012 03:48 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qapi-schema.json | 20 ++++++++++++++++++++ > qemu-char.c | 16 ++++++++++++++++ > qmp-commands.hx | 28 ++++++++++++++++++++++++++++ > 3 files changed, 64 insertions(+), 0 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 3c8530f..23edda9 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -226,6 +226,26 @@ > 'data': {'chardev': 'str', 'size': 'int', 'data': 'str'} } > =20 > ## > +# @memchar_read: As in the previous patch, s/_/-/g > +# > +# Provide read interface for memchardev. Read from memchar > +# char device and return the data. > +# > +# @chardev: the name of the memchar char device. > +# > +# @size: the size to write in bytes. s/write/read/ > +# > +# Returns: The data read from memchar as string. > +# If @chardev is not a valid memchar device, DeviceNotFound > +# If an I/O error occurs while reading, IOError > +# > +# Since: 1.2 > +## > +{ 'command': 'memchar_read', > + 'data': {'chardev': 'str', 'size': 'int'}, > + 'returns': 'str' } Again, is there going to be a binary encoding issue? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE20A354BD23D8B82BB9E39DA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGVB+AAoJEKeha0olJ0NqyJoIAJq7n1N992dn73BsAbP9So5m KxG4zvf/ZgwcIsE31dTiXtvuAMsZLWm7ZzMUWKMViq67QcRPQKdHwjKz0Zt+1LQH WHql2DDAVSq/JLe4EknVe7ztWTt/NIgtK5to8Sv+vsDk8RxFBTg6nbbyVamUKaV3 9ZiFmBrPvFxd3nrAWMOk/phmUYc65+pUlLpoE2vr9KsMKro+7mo+U6kiw0IgAPNk eJngZX1LmajOfynVf3MvVAWLFFP/igj8JTwsV2gAwEK9G1z5/4NViVroTK7ythrP Os3ptj5QOIlIrQaCfrbOQv1ns6wBnI4g4sHdzUqTxE6SrnKhlF0+LH2vXo7SW34= =nmDp -----END PGP SIGNATURE----- --------------enigE20A354BD23D8B82BB9E39DA--