From: Scott Wood <scottwood@freescale.com>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: KVM list <kvm@vger.kernel.org>,
"qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>,
Alexander Graf <agraf@suse.de>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog
Date: Wed, 1 Aug 2012 13:00:49 -0500 [thread overview]
Message-ID: <50196ED1.70602@freescale.com> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D03DE3C71@039-SN2MPN1-023.039d.mgd.msft.net>
On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote:
>
>
>> -----Original Message-----
>> From: Alexander Graf [mailto:agraf@suse.de]
>> Sent: Wednesday, August 01, 2012 7:57 AM
>> To: Bhushan Bharat-R65777
>> Cc: qemu-ppc@nongnu.org List; kvm-ppc@vger.kernel.org; Bhushan Bharat-R65777;
>> qemu-devel qemu-devel; KVM list
>> Subject: Re: [PATCH 4/4] Enable kvm emulated watchdog
>>
>>
>> On 20.07.2012, at 07:23, Bharat Bhushan wrote:
>>> @@ -384,6 +437,15 @@ int kvm_arch_init_vcpu(CPUPPCState *cenv)
>>> return ret;
>>> }
>>>
>>> + if (enable_watchdog_support) {
>>> + ret = kvm_watchdog_enable(cenv);
>>
>> Do you think this is a good idea? Why would real hardware not implement a
>> watchdog just because the user didn't select an action?
>
> If there is no watchdog action then why we want to run watchdog timer?
On real hardware, if software sets WRC to a non-zero value, the watchdog
action is a system reset. The user doesn't have to do anything special.
-Scott
next prev parent reply other threads:[~2012-08-01 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342761795-12765-1-git-send-email-Bharat.Bhushan@freescale.com>
[not found] ` <1342761795-12765-4-git-send-email-Bharat.Bhushan@freescale.com>
2012-08-01 2:27 ` [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog Alexander Graf
2012-08-01 17:27 ` Bhushan Bharat-R65777
2012-08-01 18:00 ` Scott Wood [this message]
2012-08-02 15:56 ` Bhushan Bharat-R65777
2012-08-02 20:31 ` Scott Wood
2012-08-03 0:51 ` Bhushan Bharat-R65777
2012-08-02 15:58 ` Alexander Graf
2012-08-02 15:56 ` Alexander Graf
2012-08-01 17:36 ` Bhushan Bharat-R65777
2012-08-02 15:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50196ED1.70602@freescale.com \
--to=scottwood@freescale.com \
--cc=R65777@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).