From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SwdE7-0004lC-VS
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 14:01:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SwdE6-0004Om-FO
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 14:00:55 -0400
Message-ID: <50196ED1.70602@freescale.com>
Date: Wed, 1 Aug 2012 13:00:49 -0500
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
References: <1342761795-12765-1-git-send-email-Bharat.Bhushan@freescale.com>
	<1342761795-12765-4-git-send-email-Bharat.Bhushan@freescale.com>
	<04BAA9B7-0B1D-48EA-BE36-699E4B83E1B7@suse.de>
	<6A3DF150A5B70D4F9B66A25E3F7C888D03DE3C71@039-SN2MPN1-023.039d.mgd
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D03DE3C71@039-SN2MPN1-023.039d.mgd.msft.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: KVM list <kvm@vger.kernel.org>, "qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>, Alexander Graf <agraf@suse.de>, "kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote:
> 
> 
>> -----Original Message-----
>> From: Alexander Graf [mailto:agraf@suse.de]
>> Sent: Wednesday, August 01, 2012 7:57 AM
>> To: Bhushan Bharat-R65777
>> Cc: qemu-ppc@nongnu.org List; kvm-ppc@vger.kernel.org; Bhushan Bharat-R65777;
>> qemu-devel qemu-devel; KVM list
>> Subject: Re: [PATCH 4/4] Enable kvm emulated watchdog
>>
>>
>> On 20.07.2012, at 07:23, Bharat Bhushan wrote:
>>> @@ -384,6 +437,15 @@ int kvm_arch_init_vcpu(CPUPPCState *cenv)
>>>         return ret;
>>>     }
>>>
>>> +    if (enable_watchdog_support) {
>>> +        ret = kvm_watchdog_enable(cenv);
>>
>> Do you think this is a good idea? Why would real hardware not implement a
>> watchdog just because the user didn't select an action?
> 
> If there is no watchdog action then why we want to run watchdog timer?

On real hardware, if software sets WRC to a non-zero value, the watchdog
action is a system reset.  The user doesn't have to do anything special.

-Scott