From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SweHT-0004yQ-S6 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:08:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SweHS-00015p-EK for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:08:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SweHS-00015i-6R for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:08:26 -0400 Message-ID: <50197EA3.4010209@redhat.com> Date: Wed, 01 Aug 2012 13:08:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343844079-2949-1-git-send-email-quintela@redhat.com> <1343844079-2949-11-git-send-email-quintela@redhat.com> In-Reply-To: <1343844079-2949-11-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig508A5CA9281173DC60220989" Subject: Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Orit Wasserman , Benoit Hudzia , qemu-devel@nongnu.org, Aidan Shribman , Petter Svard This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig508A5CA9281173DC60220989 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/01/2012 12:01 PM, Juan Quintela wrote: > From: Orit Wasserman >=20 > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 28 ++++++++++++++++++++++++++++ > hmp.c | 13 +++++++++++++ > migration.c | 17 +++++++++++++++++ > migration.h | 4 ++++ > qapi-schema.json | 28 +++++++++++++++++++++++++++- > qmp-commands.hx | 36 +++++++++++++++++++++++++++++++++++- > 6 files changed, 124 insertions(+), 2 deletions(-) >=20 > ## > +# @XBZRLECacheStats > +# > +# Detailed XBZRLE migration cache statistics > +# > +# @cache-size: XBZRLE cache size > +# > +# @xbzrle-bytes: amount of bytes already transferred to the target VM > +# > +# @xbzrle-pages: amount of pages transferred to the target VM > +# > +# @xbzrle-cache-miss: @optional, number of cache miss > +# > +# @xbzrle-overflow: number of overflows > +# > +# Since: 1.2 > +## > +{ 'type': 'XBZRLECacheStats', > + 'data': {'cache-size': 'int', 'xbzrle-bytes': 'int', 'xbzrle-pages':= 'int', > + 'xbzrle-cache-miss': 'int', 'xbzrle-overflow': 'int' } } Given that this struct already has xbzrle in the name, do all the fields need to repeat that information? > +++ b/qmp-commands.hx > @@ -2128,7 +2128,17 @@ The main json-object contains the following: > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > - > +- "xbzrle-cache": only present if XBZRLE is active. > + It is a json-object with the following XBZRLE information: > + - "cache-size": XBZRLE cache size > + - "xbzrle-bytes": total XBZRLE bytes transferred, only presen= t if > + status is "active" or "completed" > + - "xbzrle-pages": number of XBZRLE compressed pages, only pre= sent if > + status is "active" or "completed" > + - "cache-miss": number of cache misses, only present if s/cache-miss/xbzrle-cache-miss/ (unless you heed my earlier complaint, then s/xbzrle-bytes/bytes/ instead) > + status is "active" or "completed" > + - "overflow": number of XBZRLE overflows, only present if s/overflow/xbzrle-overflow/ > + status is "active" or "completed" Given that the overall 'xbzrle-cache' struct is already documented as present when XBZRLE is active, do you need to also document that the subfields are present when active or completed? > Examples: >=20 > 1. Before the first migration > @@ -2196,6 +2206,30 @@ Examples: > } > } >=20 > +6. Migration is being performed and XBZRLE is active: > + > +-> { "execute": "query-migrate" } > +<- { > + "return":{ > + "status":"active", > + "capabilities" : [ { "capability": "xbzrle", "state" : true }= ], > + "ram":{ > + "total":1057024, > + "remaining":1053304, > + "transferred":3720, > + "duplicate": 10, > + "normal" : 3333 Inconsistent spacing around these ':'. > + }, > + "cache":{ s/cache/xbzrle-cache/ > + "cache-size": 1024 s/ 1024/1024,/ > + "xbzrle-transferred":20971520, > + "xbzrle-pages":2444343, > + "xbzrle-cache-miss":2244, > + "xbzrle-overflow":34434 and if you take my earlier comments, these lines would change too. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig508A5CA9281173DC60220989 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQGX6jAAoJEKeha0olJ0NqxvUH/i5IXaXoqXLsxt8EJ2epfOJm pC+3/r1GDoSMyUpG/NjlOcJjW82Aochl0yvLeesGBrrhi25832sDx9RMLkf9WbEw cKPm/zBTmoOF1E1IkqOAXpeww80YbpiodYqiVEG9uHjPngphYcwqtfNXktrkGZs5 iZuCU6b7F3EKFzNtXTtpPBNVFRJUX07KyJCT+h6LNXT/Vsxlr35Sk3+S1ocXZ6Wp UGQDFau2S6dI8elQrk1p8oO4zSQ2r2WCVbQRZm9K1jSrfixLat3SBX3lTRqiM27l iigVNSDtOPhFx5Fm8XOkOPv509X3pkjaweaQxnhYsNfahZGa4RBWY5Y1aaeFiWw= =+cxD -----END PGP SIGNATURE----- --------------enig508A5CA9281173DC60220989--