From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SweTq-0008PY-U1
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:21:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SweTm-00059G-Rs
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:21:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33519)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SweTm-000597-Ii
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 15:21:10 -0400
Message-ID: <5019819D.6030203@redhat.com>
Date: Wed, 01 Aug 2012 13:21:01 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <20120730213409.21536.7589.sendpatchset@skannery.in.ibm.com>
	<5019791F.1000103@linux.vnet.ibm.com>
In-Reply-To: <5019791F.1000103@linux.vnet.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enig68E2C1A1065A7AE520180820"
Subject: Re: [Qemu-devel] [v2 Patch 8/9]block: Cmd "block_set_hostcache" for
 dynamic cache change
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: supriyak@linux.vnet.ibm.com
Cc: Kevin Wolf <kwolf@redhat.com>, Shrinidhi Joshi <spjoshi31@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Hellwig <hch@lst.de>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig68E2C1A1065A7AE520180820
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 08/01/2012 12:44 PM, Supriya Kannery wrote:
> New command "block_set_hostcache" added for dynamically changing
> host pagecache setting of a block device.
>=20
> Usage:
>  block_set_hostcache  <device> <option>
>    <device> =3D block device
>    <option> =3D on/off
>=20
> Example:
>  (qemu) block_set_hostcache ide0-hd0 off
>=20
> Signed-off-by: Supriya Kannery <supriyak@linux.vnet.ibm.com>
> +++ qemu/qmp-commands.hx
> @@ -987,6 +987,30 @@ Example:
>  EQMP
> =20
>      {
> +        .name       =3D "block_set_hostcache",

QMP version should be block-set-hostcache.

> +++ qemu/qapi-schema.json
> @@ -1604,6 +1604,23 @@
>              'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int' } }
> =20
>  ##
> +# @block_set_hostcache:
> +#
> +# Change host pagecache setting of a block device
> +#
> +# @device: name of the block device
> +#
> +# @option: hostcache setting (true/false)
> +#
> +# Returns: Nothing on success
> +#          If @device is not a valid block device, DeviceNotFound
> +#
> +# Since: 1.2
> +##
> +{ 'command': 'block_set_hostcache',
> +  'data': { 'device': 'str', 'option': 'bool' } }

Here as well.

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig68E2C1A1065A7AE520180820
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJQGYGeAAoJEKeha0olJ0NqYF4H/3/5tpPk7kf9DzVaqTUK3Wts
rtMIR0qRjb8PoV4Wuk0c8tT2D6KAvfm2VD1d/6etFVmvzMPaSfpgaMACCGF5lPSf
8hYXd9wrrg0pzx63oEtCu/444qMs20AMT572OuT/YsZbXqUxbyjt9Y8ORCLWzOcY
FOakx7VW9PUDm/UcMaQq/oviw297wfdpaeCggxqaq1zRnB82z45Uz3RAGkWxU/Zv
nRLF6FJUTvW3dhQfyJfMXAjqGP2HiFLJ2mFrwN6A9mrcRvh+Wq0D65E6w/ax0zlo
6QLX4vytCykVCd8zqtamI+Ycx3WYnHbjI7D+2p0k2Wulbr5SrIFNvmv/e/YVTrs=
=DLpL
-----END PGP SIGNATURE-----

--------------enig68E2C1A1065A7AE520180820--